[bt-devel] close button on bookshelf dialog

Jaak Ristioja jaak at ristioja.ee
Sun Jun 26 12:38:40 MST 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dear Gary and Martin,

I reverted Gary's addition of the close button to the Bookshelf manager
also because it was actually more-or-less a revert of my removal of the
close button back in September (commit c277ce) even before 2.8 beta, so
this has always been in the stable-2.8 branch. I even documented this
feature in the ChangeLog and announced the bookshelf manager redesign in
the 2.8 beta release announcement. You and Martin released Windows and
MacOS binaries of 2.8 beta. I might have bad memory, but I really don't
remember anybody objecting to my GUI redesign back then. So I've been
very happy about the redesign ever since. And I still am.

I'm very sorry, but you're just too late trying to take this up now.
Where were you when the discussion should have taken place? :|

On 24.06.2011 17:09, Gary Holmlund wrote:
> I believe a close button
> belongs on this dialog for usability reasons alone, even if a close icon
> is in the upper right corner.

I disagree. We should strive for simplicity and not duplicate such GUI
functionality (the KISS principle). Such waste of screen space harms
usability, especially on small screens (e.g Meego devices?).

>> Also, Meego does not put any window icons on their dialogs. There is
>> no work around for closing it on Meego.

According to
https://meego.com/developers/ui-design-guidelines/handset/designing-your-application
Meego appears to have a "close" button. Please tell me if I
misunderstood that text and those figures.

The current Bookshelf Manager GUI works well on Windows, KDE and Gnome
2. Gnome 3 has a bug which prevents it from working, so this is not an
issue we must work around in BibleTime. Has anybody even run it on
Meego? Any other platforms with problems?

This is not a bug. This is a feature introduced more than 9 months ago.
IF and only IF there is a serious reason to re-introduce the close
button, it should be done using conditional compilation (e.g.
#ifdef/#ifndef). The default should be to compile without the close button.


God bless!
Jaak


PS: In the future we should probably also discuss about simplifying the
MDI stuff and everything related to the subwindow toolbars.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)

iQgcBAEBAgAGBQJOB4q8AAoJEHeFv6jk2xWmsTg//1GUfMzzvLoET3b2mmvCJYOm
Qvrcd3B23v4pHJihfyaiL6echiDptNh9bHsq1kwJmh40Eg3R5FHpk5JBZA5Xxoz4
ISc5DxKQZKfLxQHdP8UyWIL1uMZdOGlXbcKmBfpA9K5uxKCeu7rwf2GZHqKbkpe9
P818hw8xyM7x1gCkIhzZPis2eHb1eRJRz4t6wpT7KJZgaA12WmFxPxBl0tXxd0hT
5O3CvP2AIsr9e5W7owXO0rHWfeP6SmaWvppiFpcsnmJXsPXk8C4DaejqyTeUQz3G
+I5heb4fPQ0Fza0HqL7ll32ss2UXqZdQYk9idZ5YZ5Y/qolkh80i01c3YHMXNvD0
P3G6K4C0V7rSnTzmXu7RAMrUNzxaWIa50xDf0IY//zEGjAN5PZKv0kHPZEG0FN4X
Uhc4+qS9J2gQCjUn0VYhuFxdr8qLlk3UDsR+GgKo/F9AS59IH5gBus8eaUKnuauf
hLIvsJ9Gm4Us13rhcE1yKfdrqSSd33zz5kbUzFzyKpxF4YHx8K0AvgWiBCM4a1EO
1J3DIIRCJ0nzgwyond0xLk5Ywp+hSRqm7Bk2cLRSi0FeiZlaKRgq59A6HYHwG4GF
+lNixefDEKx+2sVnaBTcg0Ujxhwy/43HGg00qH+CmFKcPxgar1HgdoPlLYVqehRa
RRKsGHFDVBjGvjmjfuEf3hJh4U8s60EJwUTXHhMp+ABwp+J+lxu2vTRlbbeckm7s
2bHuzIblUvp7vixi6DtveXwN12BsTujifsoW5i9jaKGGaz12ino7K57G5Rmn4jYI
l2yCNyL/a0XWgiMTs99EAtTEmSAhvSZkSfapggu97Q9Ng50pm5yR6cFxnv2Rxyo7
3Y24ZEfZb68laudFvA840IWKtKoUz8M9Emb6tvz4Y4fPUTwrW5Lx2Drbq+SDf+m0
5fYCkEEAg1LjccfGJ6LEFOdsaCbO33t8oZDaCV50/nqq1tUgUUzTZf6RN9vOzZ1/
X7w9+G128849teXDYMx+zL+5fgfpP6/uYcqI0TatA1b6Mk3LCizRbMBDV1Rl7QJP
7jUBDVxujf+O5hBo+/S24gP2AsQYFahAQwedSXzH1jL4x8zHKe+K0xo0/FhvoItC
gu2/uIue3P1bLSETsHlYESBpbgrgjwA27oHp5DZwV3QUtynEvjYEHmLVpw4tlvo/
7H45LJKEvO90sISBCpbUSqSlcbXFspfkIKBNJqk3TMalhkE/zI13jC3/ddAg+tT5
SNsvMnSLaYBEJgZlQqwgpTZqBN6WbaVf/j9DE+EVF1uRtD//60f9wmWRelv7YylI
wn126m0/K3LQ3L9UkJehYzotYYKTvr7BS7KewAQkkssjhRwmvEi0KysXqmh73NFa
Xoljylzz396JPpur+k1dHRHlJp1643JRzxK/zd13pOpupMTO9gJ7+txGQTCV4j+/
NyQVZKC3rtCpmofsyopjMXGdSDCFuVFbQhMUR6+uzaVgFumztKf3LXzTayqs2z5+
EnXkQTLiyFKwVRCcauWBEBltUcZPMuzZ+sxbr6laoJQj6SRpxpVkJdzleoQ56+xr
bzWNPqbH77+yEDrF1zv35doLQwi+7tN+q1j8regT6Yb4J1YCkWknccAyeLhB03Un
0/IMM72R0rk06svbPH8RKje8V0AZAnr9dQut7aGzo5zw582Iz9qkbhbBdHeO64DR
TO46afrIh1Bbl7ZzNrF40e84sScKETJgNar9qJXsAT+nl4rXQGCFyxIhRvFokiM7
0PV+jazRR76Pic/RQJTT62LPe3rQEuFO0eWhGh2a9vVzG4q3E1OUXwDAz6kDREOi
nFoiKOLRk63H9V0PnmNeVYlgxYHWOFPZhUAb3kAKcFafppo02bcNxWhSOCkimwTt
puNajIUMxCTWA3KT9d2NVGiM6H2oA4E7xWdkqEpCNoDcLlhS/moeZ+Eq1dCj2vdw
GF6qsiFHCGsgMZEMHrbqB4ETIgRwBxE8OECnrGTppf/LHMzlpc4t89igHANynneO
fZcjU7f25/rMPw8nbtUW53VZaXLPzfsneYmGymy+IJbIo2TkfQAl7W59JTu1F/ns
1IH9/aIZPu/WIuncVJMQY75lT/V0e8FFvqrQQoH7I/O85BLufQOqZqML5R7Bk0vk
2mUPnqmoOd/MfsbgmrngWJ2+ZBF8P4LTLuyXFh1RONI4fB6s5hk2Q0Nt9/hzbLme
QxEvVUP/rQ+H82CwP+7FNVjwjBF8A/zoC1Jr3FdH4WcUI9vKMXiWzWnndEpoGHKs
Qfevpu+0uNlUoNk51NIHaR97hvCGdK4AWPX2Jz6f7QkaVRXfpN2lzh4J7nsdVCzE
+nOA6fZ274XCKNL6F/aA4HKni0joFCuUsXnuHI2HhIIOWTOQCs6n/o2e8d+o0Tc+
bSeuUbEM3uSOSMUjDb8WfiWa+QfkjdGGoBC0k/f+7UyWE7lJ6hhQkSoDDgaoSMjF
YHm7Mf2ZUDB7is4ueBYVaYnFpPZWc3kKfLqsFeRsmrO3YlkxXWJ5tzb2V1uGsnAX
x8KBmtpdNqMTmqGa/l7HXLopbFdHRDQJhIvkvAaGhWfpKC4YTxl0kZhEVCLJxb2G
GteLNylxUVWqdve6qKmiI4wDwDhGOKFM3TTvWoC4OnjqzsozuMOggOwwoecaG+Jb
o94LlO+sLejPaAfjdAmRoaOGA975xRy376pTixmF9wlko+DQaqEgM+3MiKF9LebT
uwWy96X+h002T9n59fxZ
=opLL
-----END PGP SIGNATURE-----



More information about the bt-devel mailing list