[sword-devel] Footnotes in Titles
Cyrille
lafricain79 at gmail.com
Sat Feb 1 16:17:43 MST 2020
I'm not sure to understand what you are expecting, I hope this can be ok
for you:
<title type="x-s2">This is a title<note placement="foot"><reference
type="annotateRef">1,1 </reference>This is a note</note></title><lg><l
level="1"><verse sID="Ps.1.1" osisID="Ps.1.1" n="1"/>First part of verse
1</l>
<l level="1">Second part of verse 1</l>
<verse eID="Ps.1.1"/></l>
<chapter eID="Ps.1"/>
<title type="x-s2">This is a title<note
placement="foot"><reference type="annotateRef">2,1 </reference>This is a
note</note></title>
<p><verse sID="Rom.2.1" osisID="Rom.2.1" n="1"/>This is the verse
1<verse eID="Rom.2.1"/>
Le 01/02/2020 à 16:51, Troy A. Griffitts a écrit :
>
> Dear Br. Cyrille,
>
> Your patch to osisReference.xml is more than I think you intended
> (attached to this email for reference). I don't wish to try to guess
> what exactly your new test is. Please, could you send only a simple
> change to demonstrate what you want to test.
>
> Thanks again for your time on this!
>
> Troy
>
>
> On 2/1/20 1:56 PM, Cyrille wrote:
>>
>>
>> Le 01/02/2020 à 15:42, Troy A. Griffitts a écrit :
>>>
>>> :) Thanks for the info. It does help a bit. It sounds like
>>> osis2mod might be (properly?) putting the note/title in a different
>>> location (chapter/book intro instead of vs 1, pre-verse instead of
>>> in-verse) based on type. Just a theory. Would need to test.
>>>
>>> What I would ask is, if you look at osisReference.xml and see the
>>> note I have placed there for testing (which works), if you could
>>> proposed an addition to that file which would represent a note which
>>> you have found that does not work, that would greatly help me
>>> comment on or debug the problem.
>>>
>> Done in the attached file, but I'm not sure I wrote all well...
>>>
>>> Thank you for the time you've spend looking into this,
>>>
>>> Troy
>>>
>>>
>>> On 2/1/20 1:23 PM, Cyrille wrote:
>>>>
>>>>
>>>> Le 01/02/2020 à 14:21, Troy A. Griffitts a écrit :
>>>>> I don't think you understand. I didn't make any changes to SWORD.
>>>>> SWORD has a suite of tests which we run to check to general
>>>>> functionality of the engine. They are "regression" tests to be
>>>>> sure we don't break something when we make changes. They are in
>>>>> the source tree under tests/testsuite/ You will find them here:
>>>>>
>>>>> http://crosswire.org/svn/sword/trunk/tests/testsuite/
>>>>>
>>>>> You'll find there, osisReference.xml in which I added a footnote
>>>>> in a canonical Psalm title and the output included the footnote
>>>>> just fine.
>>>>>
>>>>> Bishop is compiled with a fairly recent copy of the engine, so it
>>>>> should also work. In fact, I am almost sure I remember seeing
>>>>> cross-reference links from notes in your headings in the PorCap
>>>>> module.
>>>>>
>>>> Probably in Konvb, we don't have yet notes in PorCap.
>>>>> Hope this helps clarify.
>>>> Yes! Now I understand better. The problem then is more complex.
>>>> Sometimes the notes are well displayed, sometimes not. By instance
>>>> if the title is in the Chap 1,1 of Psalms, the note is not
>>>> displayed. In all the next chapter it is ok. But in all the other
>>>> books the notes in the titles are never displayed. (In KonVb) If I
>>>> add type="xxx" within the <title> the note is note displayed.
>>>> Then I did some tests, and I discovered if I use the <lg> tag, the
>>>> notes are well displayed, except for the chapter 1.
>>>> If I add the type="main" or "chapter", the note is still well
>>>> displayed, but if I add a custom type like type="x-s2". The note is
>>>> not display.
>>>>
>>>> I hope this can help you for debugging the issue.
>>>>>
>>>>> Troy
>>>>>
>>>>>
>>>>>
>>>>> On February 1, 2020 6:47:01 AM MST, Cyrille
>>>>> <lafricain79 at gmail.com> wrote:
>>>>>
>>>>>
>>>>>
>>>>> Le 31/01/2020 à 23:38, Troy A. Griffitts a écrit :
>>>>>> I didn't fix anything. I commited a test to our test suite to
>>>>>> check a footnote in a title.
>>>>> Ok can I have this test and try to compile a new sword package?
>>>>>>
>>>>>> On January 31, 2020 9:27:34 PM MST, Cyrille
>>>>>> <lafricain79 at gmail.com> wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>> Le 31/01/2020 à 20:06, Troy A. Griffitts a écrit :
>>>>>>>
>>>>>>> Guys, has anyone actually written a test for this ticket
>>>>>>> API-180?
>>>>>>>
>>>>>>> I have just added one in the latest trunk commit and it
>>>>>>> seems to work fine for me. I used a note similar to the
>>>>>>> example David has in the ticket and the output and
>>>>>>> entryAttributes both look correct.
>>>>>>>
>>>>>> Thank you I'm very happy to read that! I hope now the new
>>>>>> sword release :) Did you already use the commit with the
>>>>>> Capuchine bible?
>>>>>>>
>>>>>>> ---------------
>>>>>>>
>>>>>>> ...
>>>>>>> <chapter sID="Ps.3" osisID="Ps.3"/>
>>>>>>> <title type="chapter">PSALM 3.</title>
>>>>>>> <div type="section">
>>>>>>> <title type="psalm" canonical="true">A Psalm of David<note n="A" osisID="Ps.3.xref.A" type="crossReference"><reference osisRef="Matt.1.4">Matt 1:4</reference></note>, when he fled from Absalom his son.</title>
>>>>>>> <p>
>>>>>>> <lg>
>>>>>>> <verse sID="Ps.3.1" osisID="Ps.3.1"/>
>>>>>>> ...
>>>>>>>
>>>>>>> -----------------
>>>>>>>
>>>>>>> Rendered Header:
>>>>>>>
>>>>>>> <h3 class="title psalm canonical">A Psalm of David<a class="noteMarker crossReference" href="passagestudy.jsp?action=showNote&type=x&value=1&module=OSISReference&passage=Psalms+3%3A1"><small><sup class="x">*x</sup></small></a>, when he fled from Absalom his son.</h3>
>>>>>>>
>>>>>>> <br />
>>>>>>>
>>>>>>> ------------------
>>>>>>>
>>>>>>> Entry Attributes:
>>>>>>>
>>>>>>> [ Footnote ]
>>>>>>> [ 1 ]
>>>>>>> body = <reference osisRef="Matt.1.4">Matt 1:4</reference>
>>>>>>> n = A
>>>>>>> osisID = Ps.3.xref.A
>>>>>>> refList = Matt.1.4
>>>>>>> type = crossReference
>>>>>>> [ Heading ]
>>>>>>> [ 0 ]
>>>>>>> canonical = true
>>>>>>> sID = pv3
>>>>>>> subType = x-preverse
>>>>>>> type = x-milestone
>>>>>>> [ Preverse ]
>>>>>>> 0 = <div sID="gen12" type="section"/> <title canonical="true" type="psalm">A Psalm of David<note n="A" osisID="Ps.3.xref.A" swordFootnote="1" type="crossReference"></note>, when he fled from Absalom his son.</title> <div sID="gen13" type="x-p"/> <lg sID="gen14"/>
>>>>>>> module->renderText(heading[0]) = <h3 class="title psalm canonical">A Psalm of David<a class="noteMarker crossReference" href="passagestudy.jsp?action=showNote&type=x&value=1&module=OSISReference&passage=Psalms+3%3A1"><small><sup class="x">*x</sup></small></a>, when he fled from Absalom his son.</h3>
>>>>>>>
>>>>>>> <br />
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On 1/31/20 4:11 PM, refdoc at gmx.net wrote:
>>>>>>>> I looked at that a lot of times and decided it is
>>>>>>>> beyond my Ken. Sorry. But the list stuff I think I can fix
>>>>>>>>
>>>>>>>> Sent from my mobile. Please forgive shortness, typos
>>>>>>>> and weird autocorrects.
>>>>>>>>
>>>>>>>>
>>>>>>>> -------- Original Message --------
>>>>>>>> Subject: Re: [sword-devel] Tei dic in sword
>>>>>>>> From: Cyrille
>>>>>>>> To: SWORD Developers' Collaboration Forum ,refdoc at gmx.net
>>>>>>>> CC:
>>>>>>>>
>>>>>>>>
>>>>>>>> The bug report is here
>>>>>>>> <https://tracker.crosswire.org/projects/API/issues/API-221>.
>>>>>>>> If you have some time to work on the sword issues,
>>>>>>>> please have a look on a more annoying issue:
>>>>>>>> API-180
>>>>>>>> <https://tracker.crosswire.org/projects/API/issues/API-180>
>>>>>>>> Almost 3 bible modules are affected by this issue.
>>>>>>>> Thank you.
>>>>>>>>
>>>>>>>> Le 31/01/2020 à 13:34, refdoc at gmx.net a écrit :
>>>>>>>>> Put a bug report in please with expected html. I
>>>>>>>>> will deal with it within the next couple of weeks,.
>>>>>>>>>
>>>>>>>>> Peter
>>>>>>>>>
>>>>>>>>> Sent from my mobile. Please forgive shortness,
>>>>>>>>> typos and weird autocorrects.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> -------- Original Message --------
>>>>>>>>> Subject: Re: [sword-devel] Tei dic in sword
>>>>>>>>> From: Greg Hellings
>>>>>>>>> To: SWORD Developers' Collaboration Forum
>>>>>>>>> CC:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Fri, Jan 31, 2020 at 9:51 AM Cyrille
>>>>>>>>> <lafricain79 at gmail.com
>>>>>>>>> <mailto:lafricain79 at gmail.com>> wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Le 31/01/2020 à 10:48, Karl Kleinpaste a
>>>>>>>>> écrit :
>>>>>>>>>> On 1/31/20 10:29 AM, Cyrille wrote:
>>>>>>>>>>> OK, then is it a problem with sword or
>>>>>>>>>>> with Xiphos?
>>>>>>>>>> It's incomplete support in Sword.
>>>>>>>>>>
>>>>>>>>>> If you look at Sword's
>>>>>>>>>> src/modules/filters/teixhtml.cpp, the
>>>>>>>>>> word "list" does not appear. In fact, you
>>>>>>>>>> can run "grep tag.getName teixhtml.cpp"
>>>>>>>>>> to get a list of the TEI keywords that
>>>>>>>>>> are supported for XHTML rendering.
>>>>>>>>> Would this deserve a bug report? Even if I
>>>>>>>>> don't think there are many people trying
>>>>>>>>> to solve the sword bugs...
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Yes, also a reasonable patch would add minimal
>>>>>>>>> code and you'd get
>>>>>>>>> <list> -> <ul>
>>>>>>>>> <item> -> <li>
>>>>>>>>>
>>>>>>>>> And you're probably done everything you need.
>>>>>>>>> A bug report with path is much more readily
>>>>>>>>> accepted into Sword than just a bug report.
>>>>>>>>>
>>>>>>>>> --Greg
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> _______________________________________________
>>>>>>>>>> sword-devel mailing list: sword-devel at crosswire.org <mailto:sword-devel at crosswire.org>
>>>>>>>>>> http://www.crosswire.org/mailman/listinfo/sword-devel
>>>>>>>>>> Instructions to unsubscribe/change your settings at above page
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> sword-devel mailing list:
>>>>>>>>> sword-devel at crosswire.org
>>>>>>>>> <mailto:sword-devel at crosswire.org>
>>>>>>>>> http://www.crosswire.org/mailman/listinfo/sword-devel
>>>>>>>>> Instructions to unsubscribe/change your
>>>>>>>>> settings at above page
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> sword-devel mailing list: sword-devel at crosswire.org
>>>>>>>>> http://www.crosswire.org/mailman/listinfo/sword-devel
>>>>>>>>> Instructions to unsubscribe/change your settings at above page
>>>>>>>>
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> sword-devel mailing list: sword-devel at crosswire.org
>>>>>>>> http://www.crosswire.org/mailman/listinfo/sword-devel
>>>>>>>> Instructions to unsubscribe/change your settings at above page
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> sword-devel mailing list: sword-devel at crosswire.org
>>>>>>> http://www.crosswire.org/mailman/listinfo/sword-devel
>>>>>>> Instructions to unsubscribe/change your settings at above page
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Sent from my Android device with K-9 Mail. Please excuse my
>>>>>> brevity.
>>>>>>
>>>>>> _______________________________________________
>>>>>> sword-devel mailing list: sword-devel at crosswire.org
>>>>>> http://www.crosswire.org/mailman/listinfo/sword-devel
>>>>>> Instructions to unsubscribe/change your settings at above page
>>>>>
>>>>>
>>>>> --
>>>>> Sent from my Android device with K-9 Mail. Please excuse my brevity.
>>>>
>>
>>
>> _______________________________________________
>> sword-devel mailing list: sword-devel at crosswire.org
>> http://www.crosswire.org/mailman/listinfo/sword-devel
>> Instructions to unsubscribe/change your settings at above page
>
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.crosswire.org/pipermail/sword-devel/attachments/20200201/d6709b33/attachment-0001.html>
More information about the sword-devel
mailing list