[sword-devel] OSIS Web Tool - Clean Markup

Troy A. Griffitts sword-devel@crosswire.org
Sat, 27 Sep 2003 10:35:24 -0700


Don,
	I don't think anyone would un-do your changes (at least not without 
talking to you first).  Looking at the log:

[scribe@www scribe]$ cvs log index.jsp


revision 1.10
date: 2003/09/24 17:11:24;  author: joachim;  state: Exp;  lines: +6 -2
fixes to parallel view
----------------------------
revision 1.9
date: 2003/09/24 03:09:39;  author: delbourne;  state: Exp;  lines: +4 -5
more XHTML clean up and added alternate style sheet. "Wash Out" will be 
the base for the new CSS.


It looks like jansorg may have committed something accidentially judging 
from his comment that he was working on the parallel view when he did 
this commit.

[scribe@www scribe]$ cvs diff -u -r1.9 index.jsp
Index: index.jsp
===================================================================
RCS file: /usr/local/cvsroot/swordweb/index.jsp,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- index.jsp   24 Sep 2003 03:09:39 -0000      1.9
+++ index.jsp   24 Sep 2003 17:11:24 -0000      1.10
@@ -18,14 +18,18 @@

     <div id="library">
         <h2>OSIS Library</h2>
-       <ul>
+       <ul class="plain">
  <%
                         Vector leaves = new Vector();
                         for (int i = 0; i < modInfo.length; i++) {
                                 if 
(!leaves.contains(modInfo[i].category)) {
                                         leaves.add(modInfo[i].category);
  %>
-       <li class="closed"><a 
href="fulllibrary.jsp?action=closeAll&amp;open=<%= 
URLEncoder.encode(modInfo[i].category) %>"><%= modInfo[i].category 
%></a></li>
+               <li class="closed">
+                       <a 
href="fulllibrary.jsp?action=closeAll&amp;open=<%= 
URLEncoder.encode(modInfo[i].category) %>">
+                               <img src="images/plus.png"/> <%= 
modInfo[i].category %>
+                       </a>
+               </li>
  <%
                                 }
                         }
[scribe@www scribe]$

I guess we need to be a little more careful being sure that we do a cvs 
update and are careful our insignicant changes don't override someone 
else's significant ones.

	-Troy.



Don A. Elbourne Jr. wrote:
> I just noticed that someone un-did some of my changes to the index.jsp for
> the "OSIS Library" navigation. I had removed the img tags so that it would
> be a clean unordered list. I then used CSS to insert the [+] graphic. I see
> that the img tags have been replaced in the mark-up.
> 
> Troy, I thought we agreed to separate the content from the style in order
> for the design to be more flexible. I'm not going to be able to help with
> this project if my changes are changed back.
> 
> 
> Don
> 
> _______________________________________________
> sword-devel mailing list
> sword-devel@crosswire.org
> http://www.crosswire.org/mailman/listinfo/sword-devel