[bt-devel] patches from mini

Jaak Ristioja jaak at ristioja.ee
Mon Dec 9 14:16:14 MST 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Костя!

First of all thank you for all the great work you are doing on
BibleTime mini!

I took a quick look at your patches.

On 09.12.2013 19:13, Костя Маслюк wrote:
> Usage of QScopedPointer<> for QDir was required for Windows Mobile
> only, because there was serious problems with static data
> initialization order. Those changes just works on Windows and Linux
> platforms, i have tested them with my own build scripts for desktop
> BibleTime.

Was it another one of these "initialize a Qt object before
QApplication" type of problems?

> Also its better to use qputenv and qgetenv instead of actual
> functions, because of lack of the last ones on some platforms. Not
> sure if this works everywhere.

I'm unsure whether the function qunsetenv is available for earlier Qt
versions. I found no documentation on it except for this rather new
commit:
https://qt.gitorious.org/qt/peter-hs-qtbase/commit/574e5cf9c510fb28781c8006a1184ca158ee859f

I think that at minimum we need to support Qt 4.8 so the patch might
actually need some #if preprocessing stuff, e.g:

  #if QT_VERSION >= 0x050000
  #else
  #endif

If you can make it work with Qt 4.8 also, then please file a merge
request @ gitorious.org for review and then you can get the commit
credits :)

> The last, i have used mutexes for config core to avoid
> simultaneous execution of some code. This quick solution helped me
> to beat exception with my project, it should not break anything but
> not sure if this is complete solution.

Yes, this does not seem to be a complete solution. It might work for
your specific case, but not for everybody. The questions is what
exactly does that mutex protect? If it ought to protect only
m_settings, then all accesses to m_settings should be guarded by a
respective lock. If the mutex ought to protect the entire class, all
methods except the constructor and destructor should be guarded. A
complete solution for this class would be needed.


Blessings!
Jaak
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQgcBAEBAgAGBQJSpjMZAAoJELozJlbjIn79WwQ//RlJZi/21h26hI/nXR20GyIF
0o2sFngviED3j3LH7EUGxd8d0QYB1Vni5cyMv1va8dRV3+RnsaTwA0xbeQt54GTF
RW4l2See840rU/sj4D8QLd8aHWl4op+SSK9oQpoljZ4MWeWFdmWbVDa+oNePBqT/
aAOZAPFFjqO2XXSPWm7nJ+ecMU+7mCwYOULMHxWDiJIjOGPMTJz3B3w4bkflRc+F
aGMe32YSrcJRCdKuU+Tm49TZqsiCtcnm4S0kGeWj+y9XwYJ2mu0z3tyYwJyk2NEN
Sz6cr0+DDaLl4qYWDfqrn1LqXH/fx7+Ra/xJkXKHhax6Fwm5SGpXtMoR3x3JTp2B
4wWBIaJpmAiB8h5MOZOQI39lr2VZEzmcAdBE8Dw95xqgwvKUtB0JLrYm07dyKU4S
6L/hvjALbhvXCdcUcpOZKKf8l2dK8JlCwN6jTUV0B1F9pK5fKFGaYLR7ii3ZqLhK
Gv/VOj+jOkXOTjmdhITlr93dViOOQMl2dUa6kPGjjhNZouzjsGwr1ToEycbrGkPy
co4mgOWUsVTTqYtRlQ8kteAtigKPRoI51tKoFL2e2UgSm6Fy7MctUGfZ89ItMY6G
VaAnjiSFL5euPkGNblb8fK3TsWTuxUyQTkv29TZI4/ifrltRc7haTy5tcmdsZABY
+d77H/kbrYii/KqByTht6wXZ7gg5/wO1TRbqUz9bH5jU2XrOC32eWNzrF2IgYbQX
FDwy4mTtpiLNOQ1+6J0HLOTfbPgx4c0fM1+N482iY2M7FXLWIootTMLddiELJbEn
KAUxD+Omoge2KelfkKd/Q8OqHDRnsVhkcq5qNRFmtb9EQ9H4dA6Zmzpm21ZK4FDt
S8bMQBT7GhiSNsh1CW4fRMHcN1kSZa0EPdWZM9t4v8M9zTaao13qrmmA76rBpKyQ
47QesDQT7knF0iRdl5pJWty2nXmPXmrnZvm9Zx6Is40Mdh1CLbM7QpfzW2VbnFOJ
tZsCCK+DtD1jffKKMFRBWqTciKJoiEzZw3rVhoM8vKiRualvRoy98q88d+pOoPx9
oGLq9Kjh20jnURp+bU45ukaUwJ8BwhT37xd90H9q0K3UCI2Ypc23jjm1+cf7Ou62
JE/wU1/eEHeFWvs20SskfuGfTbHMVNs0aO/zO5aG7TZGE14H25W1G/HR7TsKSbD/
dsYgvYQxeyKZbk6Vm55pdfGIXH2pIW2bKTN4aAH0IW9M+gvAc65D6XsR2ec2Tct7
JT1t/I/jKH8tVVD8g5adADndv6Rudbtd8FirbydjooLd1IQF1xihfd/0ttoppUNO
91GcX/XPjnt/b6y4GFVRSKpcYnC0QdDD5HVypvWSKHYTH1nuexIHsuqLMrsDaOLL
kcYzCYY3IJwkYYEMHJrM5vQTgD+9rFasXvf8yhOHz2g/zfbenrJd+MdO/vyRSRZD
HTttFDcUtbgWN+vsXizVmYjGdL7DkqQzXUQ9MjHsgk56X5i3JT/u+NTTP1re626F
QbWiib3XfChOQVFmtvQ+9B5l/5Eqxs97Qu8pnuQpl3IuoOsrK/JapNsG19faHOx8
PCiRo0tDtV8gemiUd1qPPfNv/HGSOV/3MSZVBmoVgPDmF7d1U3f1B8UMwRn86RPy
ZoZkOJb8fd8NvEb/JxAvHDdu86g+eEfU4331Z6SvBa4TlJ10Bh5zRIzrbY4K1WSZ
0+mwBYdG4sIHm646wUKLi0U5yIfcQpQkuO5yx21ys8d6AmshI9jpya/InYzfsjv1
IfNS35OW6R9/ecMcFR+cwedKfALMGBQb3xDX56ELfCkvn/aECeZ6Oh86Zeoos14L
ToaTQPbTvl3t33yLf6uCjhHcYjyYfEgkrbgzYUtLo7d/QZinPrJVfmUDwo66VCOW
b6srIeLyZilmcS6hk/s9dLWt4k0kwo6d/JsELQPrLkcL1KEv995ooMDA6wcJpV3j
1R291GYILZQAyzqUfoG90vDo5CKetRlLDjed5dyQ6DI7YLhm1E8gi8dzayp2ihRg
K2RyYFnnyNZI2YwNCsWGbhf5PQAs7+NTc3B8Tq/7ZMYayjwPQGv4yIUqgFNgAOBh
kxeLd5ji82jsQSkObjpTDQGhYlKU0hH/MEvZIlicidXDjNgLi6JdScuhUgkDXTPJ
CvD/1K/q1y94l4cn6L0DHm+mT9sxx0HhWOu+M66JA+TkRX9HyuJS7xWeEgbSFp3z
yBWY79WY2HBlAzp+vONbiDTfOGg/o33QPoo2xomSqEwIofetWmplt/OerPxBQzAi
tIQYz6SdzqGU5KqM5DwXldRiwZ8bS8ntZosfROSGF156VI7aRKrwCXpCVgY2nMi1
FinhKROWyVfdSLEbGFjDPHPzqaGHxaiXiO14/Y07aMWh0wNw8PEp9AmAX1K4gcJb
YJDPiIwGTFm8bZqgF8pqRK0vmmqXA0Fd0M7Bqwub/GI1O8TCvp+Y60uL3WMpAnvQ
XJoHHuExbZleBVVlVEHPwSKQOfvStf9u6oPcE2nXl1DWR7cFhrO09jxnRVGYDJGR
LCIVC1mta2Jt+7qqNE8DU1rKNrT5GTAnrKa/vXr4cMhh1NK4Lx7gwFftAWgMF2d3
LtyuKWyp7dFTRbX4znzwTdOTa9Lf2D79Vqt3S6cbshQKGhYchXqF7BKlOtN/5xMN
kdFNNNnmHLEKpfNt18W4x5wcQNYYk16Jp425d06x+Ur/xT7sck/vTtDrW+iqCSu4
1mm832JzxlyYF42ZSSrQ
=4Xz0
-----END PGP SIGNATURE-----



More information about the bt-devel mailing list