[bt-devel] Serious personal commentary overwrite bug - FIXED

Jaak Ristioja Ristioja at gmail.com
Fri Mar 4 13:14:57 MST 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04.03.2011 07:13, Gary Holmlund wrote:
> Jaak,
> 
> I found some more problems with the Personal Commentary saving. I have
> fixed them and checked them into the master and stable-2.8 branches.
> 
> It all related to methods of changing the Bible verse reference key
> (CSwordVerseKey). There are several ways it can change:
>   3 drop tabs (Book, Chapter, Verse)
>   3 next arrows (Book, Chapter, Verse)
>   3 previous arrows (Book, Chapter, Verse)
>   Forward and backward history
>   Direct entry in toolbar
>   Drop of bookmark
>   Synchronized commentary change with Bible change
> 
> Each of these methods has a slightly different way of signaling before
> and after key changes. This part of the code is a mess. I believe I have
> the problems fixed and a release of stable-2.8 is ok. I believe I can
> cleanup and simplify the code doing key changes and will probably
> continue working on that in the master branch.

Great!

> PS. Why do we format code so it looks like this:
>      if (expr) return;
> 
> I can't set a breakpoint on the return. It should be done like this:
>     if (expr)
>         return;

Good point! I've never thought about this before. Having the return
statement on the same line means less lines-of-code and looks prettier
in some cases. But of course this doesn't outweigh your debugging
argument. For me personally, the harder part is to remember to code like
that, but I'll try. :)

God bless!
Jaak
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)

iQgcBAEBAgAGBQJNcUg9AAoJEHeFv6jk2xWmDnxAAJKnLghx3eO6ENBxcLjZW17f
UMF/A1g+fzbjANV6jy0SxPohc0smCIzah2mPniexSQ3Kt7HmyzaSZ30YjyYxmZ4d
6ue2RmNRu14t7eocGVXccfg1iEJaLJHI6iDuhblHsMabRV6BHLKC1khVbTPPtZHV
fG26mUHO8owtI9ZPJIKLnWN1iJsby+CbEZ3Fm0+BzhXibeQIHUDdp/D3zA3VP1be
hVRbHJX4f61d+SzXzebv9Pwc+SE7k9HiXVKtAl4I6zCWmpH0vec3fl/MDWf2jael
aCYwYvj/FF8WXxZ8WC0IjRDZQzvlg++G/UpCtOeaS/yCz7CqkufWtNxVXnLb9wUb
NBrvlOS2pC7trxyJOUE2lkxHzClJoAv6J8ho0kLLNJIeahcio2CfMS8NaEyXfmGl
VktG6FoO0AXOsmSW/R2Sb7fvZaymTiBkoyDUDdu/Rb6ejb3m+szjY/Nr4ymMHpMw
QfIE6Qyvlq1+ZDNiBpqfOQ0g0yfWTv1wuZwosC6aNkLk9gM1/rkPcdZPTh5UAcby
h3xMX2eCnlgaaghATgeokM4hM8P9lLrJlFJxeCVo2N80GmOKrMiQKIL1oVOu3+80
s8InHN14EpPyej70OtLkt7c/y1RX/ZoCYL3h/0p0dInJzhOkLyPU+b7oODeRiIgz
eooKFRg+Ms3zfSAmbah/qmw72NBP4aWBZixwbSxZrrs1J7dUPZU4vCM2M0NNXAeh
nNr36Klq3vNlcm360Z6KZBsrTZ4zcejpeHNp+pdTj8llcjqMUfiurXTQ5Z+7U4ZQ
Z2sENLP59c0J1S3I6Hf+hpXIM2Ll44QfhYEIxH5LkJcunw0XQJCa12aBt9bN/UHx
VLwZCUhnPPu7Gi4mplyW930dBo8U/S7lZAZoBsxxPfWzXkCqwB5pjUdFt/4wFvMg
hgwWYOX6cFBHo5iuPMbdeRfes6Y7EyfrsBLaKnDLDbInMUTAPHJY335BamtdgjAB
90E9Vs6q7c++v+V22JaJQyq7CM/62Zfyj6fcLLV6yq13ZFB6Kmr6Vvkht0AM/L3Z
wAlegP9yZLvESbgrlb7HdLoGf/mVpEmf7phPc+Tg19bNEzi+zbXRW9Mdbz7cKR1j
i56r8bO3xoM8SjsExbSZi2izNFxxfXHvMZCoNFLRh8JRkZJ6DSgPibZwbtKJMlBe
UvgUJ6Uj9kSDdqzTFEbBMkniNS8oTHFWGGrMXUbqgiPBetmcQ2kmTkePHr0y3gUU
/0iRVp7W9kL3nMmYKIA3YB48hHwzDZM8IOr0h3deSS7KBwC+DeEfng9vDbGR6iCD
/aJwuj9a+KPR+8THC//ODYL9tErEUEakTDheMP2Z0UxNvMSj9hkh+wa2WvYnXN8P
Ixp55NeMwxYkfwWi+HTa5SFpTSHq8UlQ/a75bL2EmGdorHE4c11uU8yA8zRzTTHf
dOSUeGku3YMjStz0CqvXW1O7WSIiI5OTjSAL3roFL3IfS50hmi4jNGqOx5NCdWJ5
2LejtEV2FFlcW/4nlccwBOvTW7u2MIsrtlwqGJF6xbtpz4PkITRXMhQ6E4NUtDka
mgoKlmqHJDRXuiIFZ/1VA5Spqts969kRhDolzxJiYtAWEKWhfUvCxOIyBmGoKs2R
tzzjX2KFLVuL8CGj24iHi5JjoE4+OP64sSkILt37L2SPJtCL7twYsXUktEuPVoXW
C6rJeI3IHBmZ+/jGeeLGHBdvOnREFzdK7WcIDnxX8kMVSx1aYi+DRgvDYNgBU9ZU
x54eoV4N1Z7gyluIbbeBaj6lxfMsHoAdz+8fKhhZ0K7eDn6G6zZ0MtQqMWMoPCi/
/JiIZOM28lL97ox0dPawaEEug4r1yBaO+OXbe7jisXAiG1Zgd1B5+OSV46FA3mgO
JfbWqbB1uNTwp+d76Gs1zh+uxY8FPAeiOOSEo8JdbgigNVkpDIo0Wlth1OwPSHO6
KOxr14WWWQqLh+lYSLbd+tfjXpPVKTR8K/APo9uiwYSu2FDRoqvFMTg+7Hty9SS+
PipC1yCJIM8rQryXRI4WPVyjZCAwFMo9K40rcTsziOaQjOkeCLXkuG+quPTJxrOW
rO6DDtBovfK6cT7UJvRCLUsjouthspOufvy5kOpaAtUsovIS+090yKgDQACM+bzk
btciwWC7Pbla1fe8TsZ0wNoWdMdNgJJSqtMDGbhDV6QCxfsR35bnLGxDI2zgGqKs
zyOJqDM4lmlRTYzRFuynINU4rba1zxUuBHKQPdSlEtuq2CsQV+1kjL4rPbZ3jvvf
+XZ6PKKLZw9gyqZx7NcMD3RI48iDpBUa+zLY8vQ+5GovKuvV8+JOT8vBNlX/kjU/
3B8xEd+NSHy3R7ijnUmXj3iQv66UKqhMtsGUetyLS3t+Gw5RYFAAtC0+PqwrscUQ
s4+yeeM7ueyloaEjeBy7kqRIp2xLevTQuj4B+5Lohupt2W1Zz00QBllXVmHbq0lj
TC7DSmQ+1HdmJ8vTAxKAFxs6YGdL/1aSU9xyd42pRTlE7r4XU08CaugXLuBDgFIY
9IKDAuNgLoz/aKtMHUMbvzi0uLEd9TE1vuqp6ru+EGcoidVibnItVb74v3cy8gCo
MWkyGeG/vhulsm48qmpYB/oOldWKslRpbgg5SOIjH/7r+sKuuStdIP05IGlohtpG
OFyge3cKxhPDdElnrTi2yaaN1yyiUQ16/LQxtFV+YMDojIBSum8fFabb30kVLsPy
MQnSYx8+Ts5+LkSuD2Na
=Y/Sx
-----END PGP SIGNATURE-----



More information about the bt-devel mailing list