[bt-devel] proposal

Joachim Ansorg bt-devel@crosswire.org
Sun, 20 May 2001 22:31:05 +0200


Hi!

> The CHTML*Display classes should be reconstructed after 1.0.
>
> They should
> -no longer be derived from swdisplay - unnecessary imo
> -consist of static functions
> -have no members - do everything with #defines (e.g. html header data)
> -have no unnecessary funtions (like setincludeheader - can be done by an
> argument to the display functions).
>
> What do you think?
>
> If it's ok, I'd would volunteer to do it later.

Ok, do it if Swords architecture doesn't rely on it.

> Joachim, are you already using the cinputdialog class, e.g. for setting the
> cipher key? I just thought it is not used yet, but I may be wrong.

I use the class for the description of the bookmarks. We still use the old 
dialog for the cipher key and the group properties, because it's fitting for 
this purpose.

> Is searching thread safe yet? The copy constructors are there, but I think
> the search thread still crashes.

I implemented the copy constructors but I was unable to get a copy of the 
module.
Imagine this: 
Sword creates objects like this: "SWModule* module = new RawText(...)". The 
problem is, that I don't know how to copy the SWModule to have the 
propertioes of the right implementation-class (SWModule* copy = new 
SWModule(*module) will not work, because RawText has to be copied.) .
That's why I have not implemented it.

> Martin
>
> Btw: They will later be changed to whatever language (ThML?) we choose.