[bt-devel] backend

Martin Gruner bt-devel@crosswire.org
Sat, 28 Oct 2000 15:05:51 +0200


On Saturday 28 October 2000 16:45, you wrote:
> Hi!
>
> > Hi Joachim,
> >
> > CSwordLDKey::getNextEntry( CSwordLDKey* nextEntry )
> >
> > IMO should be
> >
> > CSwordLDKey::NextEntry()
> > or
> > CSwordLDKey* CSwordLDKey::NextEntry()
>
> You know we talked about this topic. AFAIK we said, that functions should
> get a pointer to modify to prevent memory leaks. For example if we return a
> CSwordLDKey it would probably create some memory leaks.

That is true. IMO the function should only modify this key where it is 
called, and give back a pointer to _this_. No new key created, only moved 
this one to the next entry.

> Using only NextEntry() would be bad because we can't work with other keys.

The "other key" has its own nextEntry() function.

>
> Do you agree?

No, sorry.

Martin
>
> > The argument doesn't make sense and I believe is not used anywhere.
> > Why should a key modify another key?
> >
> > That is also valid for all the corresponding functions in CSwordLDKey and
> > CSwordVerseKey. Do you agree? Should I change it?
> >
> > My question again: how ist the state of the QT license issue?
>
> I don't know.
>
> > Martin
>
> --Joachim