[PS-60] Underline tag for Chinese Created: 25/Oct/11 Updated: 06/Jan/13 Resolved: 01/Nov/11 |
|
| Status: | Resolved |
| Project: | PocketSword |
| Component/s: | None |
| Affects Version/s: | 1.4.1 |
| Fix Version/s: | 1.4.2b1 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Ko Chiu Shun | Assignee: | Nic Carter |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
OSIS support underline tag, which is important punctuation for Chinese language. See whether it can be supported. |
| Comments |
| Comment by Nic Carter [ 25/Oct/11 ] |
|
Hi again, could you please let me know of a module & verse position where this occurs so I can take a look into this? |
| Comment by DM Smith [ 25/Oct/11 ] |
|
The <hi type="xxx"> yyy yyy</hi> construct allows for xxx to indicate underline. The osishtmlhref.cpp filter does not handle that value (nor most of them). This report probably should be moved to API. |
| Comment by Ko Chiu Shun [ 25/Oct/11 ] |
|
Here is an example: <hi type="underline">AB</hi>c<hi type="underline">DEFG</hi> I know Bible desktop for PC supports underline tag. See whether pocketsword will also support it in the future. Thanks. |
| Comment by Nic Carter [ 25/Oct/11 ] |
|
Are there any other front-ends that support this? If it's only Bible Desktop, that is using JSword (Java) rather than our C++ API, which would infer that it is indeed an API issue, with osishtmlhref.cpp not supporting that. |
| Comment by Ko Chiu Shun [ 25/Oct/11 ] |
|
See whether osishtmlhref.cpp will support it in the future. Thanks for your answer. |
| Comment by Nic Carter [ 31/Oct/11 ] |
|
you'll need to give me a verse number so that I can find where this is happening in your module. |
| Comment by Ko Chiu Shun [ 31/Oct/11 ] |
|
you will see the underline tag in Matthew 1:1. you can see this script in my file. ----------- |
| Comment by Nic Carter [ 01/Nov/11 ] |
|
fixed. |
| Comment by Nic Carter [ 06/Jan/13 ] |
|
please test in v1.4.2 of PocketSword, now available on the App Store. |