Details

    • Type: Improvement Improvement
    • Status: Closed (View Workflow)
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.1
    • Fix Version/s: 1.4.2b1
    • Component/s: None
    • Labels:
      None

      Description

      OSIS support underline tag, which is important punctuation for Chinese language. See whether it can be supported.

        Activity

        Ko Chiu Shun created issue -
        Hide
        Nic Carter added a comment -

        Hi again, could you please let me know of a module & verse position where this occurs so I can take a look into this?

        Show
        Nic Carter added a comment - Hi again, could you please let me know of a module & verse position where this occurs so I can take a look into this?
        Hide
        DM Smith added a comment -

        The <hi type="xxx"> yyy yyy</hi> construct allows for xxx to indicate underline. The osishtmlhref.cpp filter does not handle that value (nor most of them). This report probably should be moved to API.

        Show
        DM Smith added a comment - The <hi type="xxx"> yyy yyy</hi> construct allows for xxx to indicate underline. The osishtmlhref.cpp filter does not handle that value (nor most of them). This report probably should be moved to API.
        Hide
        Ko Chiu Shun added a comment -

        Here is an example:

        <hi type="underline">AB</hi>c<hi type="underline">DEFG</hi>

        I know Bible desktop for PC supports underline tag. See whether pocketsword will also support it in the future. Thanks.

        Show
        Ko Chiu Shun added a comment - Here is an example: <hi type="underline">AB</hi>c<hi type="underline">DEFG</hi> I know Bible desktop for PC supports underline tag. See whether pocketsword will also support it in the future. Thanks.
        Hide
        Nic Carter added a comment -

        Are there any other front-ends that support this? If it's only Bible Desktop, that is using JSword (Java) rather than our C++ API, which would infer that it is indeed an API issue, with osishtmlhref.cpp not supporting that.

        Show
        Nic Carter added a comment - Are there any other front-ends that support this? If it's only Bible Desktop, that is using JSword (Java) rather than our C++ API, which would infer that it is indeed an API issue, with osishtmlhref.cpp not supporting that.
        Hide
        Ko Chiu Shun added a comment -

        See whether osishtmlhref.cpp will support it in the future. Thanks for your answer.

        Show
        Ko Chiu Shun added a comment - See whether osishtmlhref.cpp will support it in the future. Thanks for your answer.
        Hide
        Nic Carter added a comment -

        you'll need to give me a verse number so that I can find where this is happening in your module.

        Show
        Nic Carter added a comment - you'll need to give me a verse number so that I can find where this is happening in your module.
        Hide
        Ko Chiu Shun added a comment -

        you will see the underline tag in Matthew 1:1. you can see this script in my file.

        -----------
        <hi type="underline">亞伯拉罕</hi>的後裔,
        -----------

        Show
        Ko Chiu Shun added a comment - you will see the underline tag in Matthew 1:1. you can see this script in my file. ----------- <hi type="underline">亞伯拉罕</hi>的後裔, -----------
        Hide
        Nic Carter added a comment -

        fixed.

        Show
        Nic Carter added a comment - fixed.
        Nic Carter made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Nic Carter made changes -
        Affects Version/s 1.4.1 [ 11450 ]
        Fix Version/s 1.4.2b1 [ 11451 ]
        Hide
        Nic Carter added a comment -

        please test in v1.4.2 of PocketSword, now available on the App Store.

        Show
        Nic Carter added a comment - please test in v1.4.2 of PocketSword, now available on the App Store.
        Nic Carter made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Nic Carter
            Reporter:
            Ko Chiu Shun
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: