Details

    • Type: Bug Bug
    • Status: Closed (View Workflow)
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.1b6
    • Fix Version/s: 1.4.2b1
    • Component/s: Bible tab
    • Labels:
      None

      Description

      When there are merged verses into one, for example, in Job 3.1, verse 2-3 in GNT is combined into one verse. They are shown repeatedly even it is a valid OSIS.

      1 xyz
      2 abcabcabcabc
      3 abcabcabcabc<<<repeatedly shown

        Activity

        Hide
        Nic Carter added a comment -

        Hi there, I'll take a look into this, but would love to have a module and verse to look into – are you looking at a Greek New Testament module? Where is it from, and why does the NT have Job in it?

        Show
        Nic Carter added a comment - Hi there, I'll take a look into this, but would love to have a module and verse to look into – are you looking at a Greek New Testament module? Where is it from, and why does the NT have Job in it?
        Hide
        Ko Chiu Shun added a comment -

        Here is an example:

        -------------------
        <div type="section">
        <title type="section" subType="x-preverse">ABC</title>
        <p>
        <verse sID="Luke.1.1-Luke.1.4" osisID="Luke.1.1 Luke.1.2 Luke.1.3 Luke.1.4"/>
        DEFGHIJK
        <verse eID="Luke.1.1-Luke.1.4"/>
        </p>
        </div>
        -------------------

        and the outcome is:

        -------------------

        ABC
        1
        DEFGHIJK

        ABC
        2
        DEFGHIJK

        ABC
        3
        DEFGHIJK

        ABC
        4
        DEFGHIJK

        -------------------

        I just take Good News Translation (not Greek New Testament) as an example for the merged verse. I am doing a Chinese Bible module. Thanks.

        Show
        Ko Chiu Shun added a comment - Here is an example: ------------------- <div type="section"> <title type="section" subType="x-preverse">ABC</title> <p> <verse sID="Luke.1.1-Luke.1.4" osisID="Luke.1.1 Luke.1.2 Luke.1.3 Luke.1.4"/> DEFGHIJK <verse eID="Luke.1.1-Luke.1.4"/> </p> </div> ------------------- and the outcome is: ------------------- ABC 1 DEFGHIJK ABC 2 DEFGHIJK ABC 3 DEFGHIJK ABC 4 DEFGHIJK ------------------- I just take Good News Translation (not Greek New Testament) as an example for the merged verse. I am doing a Chinese Bible module. Thanks.
        Hide
        Nic Carter added a comment -

        Hmmm, ok, can you give me an example in a currently published SWORD module where this is occurring? I have fixed all known occurrences of this in our own modules, so it would be interesting to compare how it is done there with what you are doing? I wonder if it has something to do with you wrapping the verse in a paragraph tag? Could you please repeat your test without the <p> & the </p> in there and see what happens?

        Show
        Nic Carter added a comment - Hmmm, ok, can you give me an example in a currently published SWORD module where this is occurring? I have fixed all known occurrences of this in our own modules, so it would be interesting to compare how it is done there with what you are doing? I wonder if it has something to do with you wrapping the verse in a paragraph tag? Could you please repeat your test without the <p> & the </p> in there and see what happens?
        Hide
        Ko Chiu Shun added a comment -

        I found it works well in The sword project but failed in Andbible, pocketsword and Bibledesktop.
        Let me try to remove the <p> and see what happens.

        Show
        Ko Chiu Shun added a comment - I found it works well in The sword project but failed in Andbible, pocketsword and Bibledesktop. Let me try to remove the <p> and see what happens.
        Hide
        Nic Carter added a comment -

        Did you try removing the <p>? And did it work in Xiphos? I have fixed this now but it won't appear in the App Store for a while. I'll move on to your other issues now.

        Show
        Nic Carter added a comment - Did you try removing the <p>? And did it work in Xiphos? I have fixed this now but it won't appear in the App Store for a while. I'll move on to your other issues now.
        Hide
        Nic Carter added a comment -

        It was repeating the heading only, not the verse, but that is now fixed.

        Show
        Nic Carter added a comment - It was repeating the heading only, not the verse, but that is now fixed.
        Hide
        Nic Carter added a comment -

        please test in v1.4.2, now available on the App Store.

        Show
        Nic Carter added a comment - please test in v1.4.2, now available on the App Store.

          People

          • Assignee:
            Nic Carter
            Reporter:
            Ko Chiu Shun
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: