Module Tools
  1. Module Tools
  2. MODTOOLS-8

osis2mod does not place the New Testament bookGroup title in the correct place

    Details

    • Type: Bug Bug
    • Status: Open (View Workflow)
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: osis2mod
    • Labels:
      None
    • Environment:

      Windows 7 (64-bit)

      Description

      Pasted from email sent to Sword-devel mailing list on 2010-12-03.

      Is there a bug perhaps in the way that osis2mod processes the bookGroup title for the New Testament?

      I have a valid OSIS XML file which uses BCV structure, with the body content modeled according to the example shown here in the wiki.

      The start of the NT division is coded like this

      <div type="bookGroup">
      <title>El Nuevo Testamento</title>
      <div type="book" osisID="Matt">
      <title type="main">El Santo Evangelio según Mateo</title>
      <chapter osisID="Matt.1">
      <title type="chapter">Mateo 1</title>
      <verse osisID="Matt.1.1">
      El libro de la generación de Jesucristo, hijo de David, hijo de Abraham.
      </verse>

      When displayed in Xiphos, the title El Nuevo Testamento is appended to the last verse of Malachi 4.

      Running mod2imp on the module that I made outputs a raw IMP file containing the following lines:

      $$$Malachi 4:6
      Él convertirá el corazón de los padres hacia los hijos, y el corazón de los hijos hacia los padres; no sea que yo venga y hiera la tierra con maldición. <chapter eID="gen24108" osisID="Mal.4"/> <div eID="gen24055" osisID="Mal" type="book"/> <div eID="gen1" type="bookGroup"/> <div sID="gen24115" type="bookGroup"/> <title>El Nuevo Testamento</title>
      $$$[ Testament 2 Heading ]
      <milestone type="x-importer" subType="x-osis2mod" n="$Rev: 2562 $"/>
      $$$Matthew 0:0
      <div osisID="Matt" sID="gen24116" type="book"/> <title type="main">El Santo Evangelio según Mateo</title>
      $$$Matthew 1:0
      <chapter osisID="Matt.1" sID="gen24117"/> <title type="chapter">Mateo 1</title>
      $$$Matthew 1:1
      El libro de la generación de Jesucristo, hijo de David, hijo de Abraham.

      Observe that
      $$$[ Testament 2 Heading ]
      occurs AFTER the second bookGroup title rather than BEFORE, which strongly suggests that the module was made incorrectly.

      I was running osis2mod: $Rev: 2562 $
      downloaded from http://www.crosswire.org/ftpmirror/pub/sword/utils/win32/sword-utilities-1.6.2.zip

      Has this been observed by anyone else?
      Is this a known bug that has already been fixed by a later version?

        Activity

        Hide
        David Haslam added a comment -

        The same thing occurs when I use a milestoned OSIS document structured as BSP.

        Show
        David Haslam added a comment - The same thing occurs when I use a milestoned OSIS document structured as BSP.
        Hide
        David Haslam added a comment -

        Even supposing that osis2mod were to be fixed to correct this bug, can we be certain that the SWORD engine would correctly display the second bookGroup title?

        Show
        David Haslam added a comment - Even supposing that osis2mod were to be fixed to correct this bug, can we be certain that the SWORD engine would correctly display the second bookGroup title?
        Hide
        Y. D. added a comment -

        Unfortunately the bug is still there almost three years later...

        Show
        Y. D. added a comment - Unfortunately the bug is still there almost three years later...
        Hide
        Chris Little added a comment -

        Do you have a patch to fix the bug? If so, I'd be happy to apply it.

        Show
        Chris Little added a comment - Do you have a patch to fix the bug? If so, I'd be happy to apply it.

          People

          • Assignee:
            DM Smith
            Reporter:
            David Haslam
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated: