osis2mod should handle XML comments

Details

  • Type: Bug Bug
  • Status: Open Open (View Workflow)
  • Priority: Critical Critical
  • Resolution: Unresolved
  • Labels:
    None
  • Environment:

    Windows 7 (x64): using osis2mod.exe: $Rev: 2562 $

Description

During my work on the Hakha Version from Myanmar Bibles,
I encountered a very strange symptom even though the OSIS XML file is valid:

FATAL(NESTING): Rev.22.21: Expected osis found osisText
FATAL(NESTING): Rev.22.21: Expected osisText found osis

The lines at the end of the XML file are all correct, thus:

</div>
</div>
</osisText>
</osis>

Using the debug option -d 256, I have traced the issue to the presence of a large number of XML comment lines.

After Rev.22.21, between the </chapter> tag and the above four lines, there were 13 XML comments.
Removing all 3775 comments from the XML file made the problem disappear.

This observation was made while making a rawtext module.
The source text file was validated using XML Copy Editor.

  1. Text File
    osis2mod.debug.rawtext.log
    09/Nov/11 10:34 AM
    1.91 MB
    David Haslam
  2. Text File
    osis2mod.no.comments.rawtext.log
    09/Nov/11 10:38 AM
    6 kB
    David Haslam
  3. Text File
    osis2mod.rawtext.log
    09/Nov/11 10:31 AM
    6 kB
    David Haslam

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Haslam added a comment -

Sorry - please close this issue.

I just found that the cause was something else.

Show
David Haslam added a comment - Sorry - please close this issue. I just found that the cause was something else.
Hide
Permalink
David Haslam added a comment -

Please ignore the previous comment - it was NOT something else. I just made a mistake prior to adding the comment.

Show
David Haslam added a comment - Please ignore the previous comment - it was NOT something else. I just made a mistake prior to adding the comment.
Hide
Permalink
David Haslam added a comment -

The log file (without debug) for osis2mod done with all the comments in the XML file.

Show
David Haslam added a comment - The log file (without debug) for osis2mod done with all the comments in the XML file.
Hide
Permalink
David Haslam added a comment -

The log file (with debug) for osis2mod done with all the comments in the source file.

Show
David Haslam added a comment - The log file (with debug) for osis2mod done with all the comments in the source file.
Hide
Permalink
David Haslam added a comment -

The log file (without debug) for osis2mod done after removing all the XML comments from the source text file.

Show
David Haslam added a comment - The log file (without debug) for osis2mod done after removing all the XML comments from the source text file.
Hide
Permalink
David Haslam added a comment -

The last lines of the source text (FIO) are:

<verse sID="Rev.22.21" n="21" osisID="Rev.22.21"/>
Nan dihlak cungah Bawipa Jesuh vel cu um ko seh. Amen.
<verse eID="Rev.22.21"/>
</p>
</chapter>
<!--Original typing: 3 July 1997 -->
<!--Revised: 6 October 1997, 3:20pm, Sui Mawng. -->
<!-Revised: 7 October 1997, 1:30pm, Sui Mawng.->
<!--Revised: 28 October 1997, 9:10pm, Sui Mawng. -->
<!-Revised: 19 December 1997, Chinchin.->
<!-Revised: Saya That Lian & Sui Mawng, 12 May 2002, 11:24 pm->
<!-Double checked: Saya Khen Cham & Sui Mawng, 10 June 2003, 5:34 pm.->
<!-Sui Mawng, 1 March 2004, 11:48 pm.->
<!-Sui Mawng, 3 March 2004, 11:17 am.->
<!-Sui Mawng, CACC, Yangon, 10 March 2004, 00:39 am.->
<!-Sui Mawng, CACC, Yangon, 7 August 2004, 11:48 am->
<!-Wordlist a voi hnihnak ka chuahmi nihin ah hin a chek cu kaa lim tiah ka ruah ko cang nain Typesetting ah òha tein zoh òhan a hau rih lai.->
<!-A voi hnihnak ka chuahmi nihin ah a voi hnihnak a chek ka dih.->
<!-Sui Mawng, CACC, Yangon, 18 August 2004, 5:00 pm.->
</div>
</div>
</osisText>
</osis>

Show
David Haslam added a comment - The last lines of the source text (FIO) are: <verse sID="Rev.22.21" n="21" osisID="Rev.22.21"/> Nan dihlak cungah Bawipa Jesuh vel cu um ko seh. Amen. <verse eID="Rev.22.21"/> </p> </chapter> <!--Original typing: 3 July 1997 --> <!--Revised: 6 October 1997, 3:20pm, Sui Mawng. --> <!- Revised: 7 October 1997, 1:30pm, Sui Mawng. -> <!--Revised: 28 October 1997, 9:10pm, Sui Mawng. --> <!- Revised: 19 December 1997, Chinchin. -> <!- Revised: Saya That Lian & Sui Mawng, 12 May 2002, 11:24 pm -> <!- Double checked: Saya Khen Cham & Sui Mawng, 10 June 2003, 5:34 pm. -> <!- Sui Mawng, 1 March 2004, 11:48 pm. -> <!- Sui Mawng, 3 March 2004, 11:17 am. -> <!- Sui Mawng, CACC, Yangon, 10 March 2004, 00:39 am. -> <!- Sui Mawng, CACC, Yangon, 7 August 2004, 11:48 am -> <!- Wordlist a voi hnihnak ka chuahmi nihin ah hin a chek cu kaa lim tiah ka ruah ko cang nain Typesetting ah òha tein zoh òhan a hau rih lai. -> <!- A voi hnihnak ka chuahmi nihin ah a voi hnihnak a chek ka dih. -> <!- Sui Mawng, CACC, Yangon, 18 August 2004, 5:00 pm. -> </div> </div> </osisText> </osis>
Hide
Permalink
David Haslam added a comment -

Strikethrough is just a quirk of the wiki software used in JIRA.

Show
David Haslam added a comment - Strikethrough is just a quirk of the wiki software used in JIRA.
Hide
Permalink
DM Smith added a comment -

Good catch.

The real reason is that SWORD's utilxml.cpp does not support comments. I suspect that there are other things it does not support either.
We could change osis2mod to look for comments and ignore them. (I think this would be good.)
If it is not in the osis2mod wiki page, it should be noted that comments are not supported, at this time.

Show
DM Smith added a comment - Good catch. The real reason is that SWORD's utilxml.cpp does not support comments. I suspect that there are other things it does not support either. We could change osis2mod to look for comments and ignore them. (I think this would be good.) If it is not in the osis2mod wiki page, it should be noted that comments are not supported, at this time.
Hide
Permalink
David Haslam added a comment -

Added http://crosswire.org/wiki/Osis2mod#XML_Comments

Show
David Haslam added a comment - Added http://crosswire.org/wiki/Osis2mod#XML_Comments
Hide
Permalink
DM Smith added a comment -

I've changed the summary to reflect the need.

Show
DM Smith added a comment - I've changed the summary to reflect the need.

People

  • Assignee:
    DM Smith
    Reporter:
    David Haslam
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: