Details

    • Type: Bug Bug
    • Status: Closed (View Workflow)
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:

      Windows 7 (x64): using osis2mod.exe: $Rev: 2562 $

      Description

      During my work on the Hakha Version from Myanmar Bibles,
      I encountered a very strange symptom even though the OSIS XML file is valid:

      FATAL(NESTING): Rev.22.21: Expected osis found osisText
      FATAL(NESTING): Rev.22.21: Expected osisText found osis

      The lines at the end of the XML file are all correct, thus:

      </div>
      </div>
      </osisText>
      </osis>

      Using the debug option -d 256, I have traced the issue to the presence of a large number of XML comment lines.

      After Rev.22.21, between the </chapter> tag and the above four lines, there were 13 XML comments.
      Removing all 3775 comments from the XML file made the problem disappear.

      This observation was made while making a rawtext module.
      The source text file was validated using XML Copy Editor.

      1. osis2mod.debug.rawtext.log
        1.91 MB
        David Haslam
      2. osis2mod.no.comments.rawtext.log
        6 kB
        David Haslam
      3. osis2mod.rawtext.log
        6 kB
        David Haslam

        Activity

        Hide
        DM Smith added a comment -

        Good catch.

        The real reason is that SWORD's utilxml.cpp does not support comments. I suspect that there are other things it does not support either.
        We could change osis2mod to look for comments and ignore them. (I think this would be good.)
        If it is not in the osis2mod wiki page, it should be noted that comments are not supported, at this time.

        Show
        DM Smith added a comment - Good catch. The real reason is that SWORD's utilxml.cpp does not support comments. I suspect that there are other things it does not support either. We could change osis2mod to look for comments and ignore them. (I think this would be good.) If it is not in the osis2mod wiki page, it should be noted that comments are not supported, at this time.
        Show
        David Haslam added a comment - Added http://crosswire.org/wiki/Osis2mod#XML_Comments
        Hide
        DM Smith added a comment -

        I've changed the summary to reflect the need.

        Show
        DM Smith added a comment - I've changed the summary to reflect the need.
        Hide
        Y. D. added a comment -

        Since r2693 osis2mod seems to handle XML comments, isn't it? So you should close this issue.
        Moreover http://www.crosswire.org/tracker/browse/MODTOOLS-16 is I guess a duplicate report.

        Show
        Y. D. added a comment - Since r2693 osis2mod seems to handle XML comments, isn't it? So you should close this issue. Moreover http://www.crosswire.org/tracker/browse/MODTOOLS-16 is I guess a duplicate report.
        Hide
        DM Smith added a comment -

        Fixed in r2693. Thanks YD for pointing out that this has been done.

        Show
        DM Smith added a comment - Fixed in r2693. Thanks YD for pointing out that this has been done.

          People

          • Assignee:
            DM Smith
            Reporter:
            David Haslam
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: