JSword
  1. JSword
  2. JS-278

DivisionName NEW_TESTAMENT.contains(BibleBook) is wrong

    Details

      Description

      This is simple just misstyping (trivial/minor) but the effect could be major.

      On org.crosswire.jsword.versification.DivisionName under NEW_TESTAMENT
      public boolean contains(BibleBook book)

      { int bookNum = book.ordinal(); return bookNum >= BibleBook.GEN.ordinal() && bookNum <= BibleBook.REV.ordinal(); }

      That should be BibleBook.MATT to BibleBook.REV

        Activity

        Hide
        DM Smith added a comment -

        Oops.

        There is a bigger problem in an av11n world with book orders being different it is possible that these ranges are not all correct. At least the NT is correct across all av11ns.

        Show
        DM Smith added a comment - Oops. There is a bigger problem in an av11n world with book orders being different it is possible that these ranges are not all correct. At least the NT is correct across all av11ns.
        Hide
        DM Smith added a comment -

        Didn't fix the larger issue. Just the reported one.

        Show
        DM Smith added a comment - Didn't fix the larger issue. Just the reported one.

          People

          • Assignee:
            DM Smith
            Reporter:
            Tonny Kohar
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: