Upgrade 3-rd party QA jars

Details

  • Type: Bug Bug
  • Status: Open Open (View Workflow)
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.6
  • Fix Version/s: 1.7
  • Component/s: build
  • Labels:
    None
  • Environment:

    ant build on the CrossWire server

Description

We currently store the QA jars in SVN under jsword-support. This causes bloat.
Either use ant <wget> task or ivy to manage these. Only download them on first use.

Put the rules either in core.xml or ivy.xml

Move the other supporting files to the JSword git project.

The list: PMD/CPD, CheckStyle, Java2Html javancss, jdepend, findbugs and nsis.

Jcoverage is not longer supported as a free option, and we have the last free version that is no longer available. We should see if there is an open source option, and failing that a free option.

Note: Findbugs is done, using wget.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
DM Smith added a comment -

PMD 5.x is not backward compatible with 4.x which we use now.
CheckStyle is now 5.6 we have 5.3.
http://cobertura.sourceforge.net looks like it does coverage and pretty printing (java2html). It also contains javancss, so maybe that's not needed as an independent download.

nsis is used on the CrossWire server to build a Windows package. It is just an ant target that should be made dependent upon the nsis environment being set up. That way we don't need to comment it out elsewhere.

Show
DM Smith added a comment - PMD 5.x is not backward compatible with 4.x which we use now. CheckStyle is now 5.6 we have 5.3. http://cobertura.sourceforge.net looks like it does coverage and pretty printing (java2html). It also contains javancss, so maybe that's not needed as an independent download. nsis is used on the CrossWire server to build a Windows package. It is just an ant target that should be made dependent upon the nsis environment being set up. That way we don't need to comment it out elsewhere.
Hide
Permalink
Chris Burrell added a comment -

Can I suggest we delete this project entirely. Maven is built to do this kind of thing. You can add checkstyle findbugs pmd cobertura as part of build and can decide whether it should fail the build.

For example at work we configure cobertura to fail when coverage is less than x percent.you can add exceptions which maybe we can do initially and then remove them bit by bit.

You can add plugins in a profile if you don't want them to run all the time.

you can also configure them but let the developer decide to run them individually.

You can also set it up to generate a maven site which includes all stats reports and java doc and other custom pages.

Sorry bout typos. On phone.

Chris

Show
Chris Burrell added a comment - Can I suggest we delete this project entirely. Maven is built to do this kind of thing. You can add checkstyle findbugs pmd cobertura as part of build and can decide whether it should fail the build. For example at work we configure cobertura to fail when coverage is less than x percent.you can add exceptions which maybe we can do initially and then remove them bit by bit. You can add plugins in a profile if you don't want them to run all the time. you can also configure them but let the developer decide to run them individually. You can also set it up to generate a maven site which includes all stats reports and java doc and other custom pages. Sorry bout typos. On phone. Chris
Hide
Permalink
DM Smith added a comment -

We should do both. The jsword-support project should go away. So far, I've added Findbugs, PMD/CPD, Checkstyle to the ant/ivy build. It dynamically gets it from mirrors. I tried to get it to work via ivy and the maven servers, but it didn't work.

Chris, please feel free to update the POMs to do the QA stuff.

Show
DM Smith added a comment - We should do both. The jsword-support project should go away. So far, I've added Findbugs, PMD/CPD, Checkstyle to the ant/ivy build. It dynamically gets it from mirrors. I tried to get it to work via ivy and the maven servers, but it didn't work. Chris, please feel free to update the POMs to do the QA stuff.

People

  • Assignee:
    DM Smith
    Reporter:
    DM Smith
Vote (0)
Watch (2)

Dates

  • Created:
    Updated: