JSword does not correctly identify Red letter text modules

I'm not seeing this. In ConfigEntryType it is listed as OSISRedLetterWords.

In org.crosswire.jsword.book.FeatureType it is listed as RedLetterText

Diff of the change is below (also in pull request - I don't seem to just be able to publish that one commit however... )

— a/src/main/java/org/crosswire/jsword/book/FeatureType.java
+++ b/src/main/java/org/crosswire/jsword/book/FeatureType.java
@@ -79,7 +79,7 @@ public enum FeatureType {
/**

• The book marks the Word's of Christ
  */

• WORDS_OF_CHRIST ("RedLetterText"),
  + WORDS_OF_CHRIST ("RedLetterWords"),

/**

• The book contains Morphology info

The code that enacts the behaviour is here:

@Override
public boolean hasFeature(FeatureType feature) {
if (cet.match(ConfigEntryType.FEATURE, feature.toString())) { return true; }
// Many "features" are GlobalOptionFilters, which in the Sword C++ API
// indicate a class to use for filtering.
// These mostly have the source type prepended to the feature
StringBuilder buffer = new StringBuilder((String) getProperty(ConfigEntryType.SOURCE_TYPE));
buffer.append(feature);
if (cet.match(ConfigEntryType.GLOBAL_OPTION_FILTER, buffer.toString())) { return true; } }
// But some do not
return cet.match(ConfigEntryType.GLOBAL_OPTION_FILTER, feature.toString());
}

feature.toString() is used,

• first as a direct look up in the FEATURES enum ,
• then it is appended by its source type (our case), i.e. OSISRedLetterText/Words against the GlobalOptionFilter
• then it is looked up against the GlobalOptionFilter without its source type

There was a simple mismatch between the name of the feature type and the name in the ConfigEntry

This has been pulled in and can be resolved: https://github.com/crosswire/jsword/pull/12

Now in the main build.