Details

    • Type: Sub-task Sub-task
    • Status: Closed (View Workflow)
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: 1.7
    • Component/s: o.c.common.util
    • Labels:
      None

      Description

      Hi,

      I would like to propose a change to JSword Common Logger (org.crosswire.common.util.Logger) readConfiguration, because currently it is setting/re-applying its configuration to the global setting of java.logging. This can cause problem because many third party library which also use java.logging will get its configuration changed (reseted) as well.

      IMHO, this kind of configuration setting should be in application specific (eg: BibleDesktop, Alkitab, etc) rather than in common library.

      So I propose to

      • move the readConfiguration from org.crosswire.common.util.Logger (establishLogging -> readConfiguration) from common to application specific eg: BibleDesktop
      • or add the following public static method to org.crosswire.common.util.Logger which allow the user of the API to disable the readConfiguration
        public static void setEnableReadConfiguration(boolean b) {
        established = b;
        }

      note: I found out this issue because the above readConfiguration re-applying/re-reading logger configuration
      will mess up Netbeans Platform (our platform framework which is used in Alkitab) logging.

      Cheers
      Tonny Kohar

        Activity

        Hide
        DM Smith added a comment -

        If you migrate your code to use slf4j (i.e. don't use o.c.c.util.Logger) it won't be brought in.

        o.c.c.util.Logger is going away, but it retains the old behavior.

        Show
        DM Smith added a comment - If you migrate your code to use slf4j (i.e. don't use o.c.c.util.Logger) it won't be brought in. o.c.c.util.Logger is going away, but it retains the old behavior.

          People

          • Assignee:
            DM Smith
            Reporter:
            Tonny Kohar
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: