Details

    • Type: Improvement Improvement
    • Status: Open (View Workflow)
    • Priority: Trivial Trivial
    • Resolution: Unresolved
    • Affects Version/s: 1.6
    • Fix Version/s: 1.6.1
    • Component/s: utilities
    • Labels:
      None

      Description

      The jlfgr jar contains icons from Sun, now Oracle.

      They were a nice way to get "standard" icons. However, they never became "standard".

      By replacing them, we simplify dependencies and help our development of maven builds.

        Activity

        Hide
        DM Smith added a comment -

        It would be good to get vector graphics for these and convert that to images so that we can have appropriate sized images.

        The description of the icons is here:
        http://java.sun.com/developer/techDocs/hi/repository/

        Here is a listing of what Bible Desktop:
        (Note: cut and paste are not currently used, but are referenced in comments for future menu items.)
        toolbarButtonGraphics/general/About16.gif
        toolbarButtonGraphics/general/About24.gif
        toolbarButtonGraphics/general/ContextualHelp16.gif
        toolbarButtonGraphics/general/Copy16.gif
        toolbarButtonGraphics/general/Copy24.gif
        toolbarButtonGraphics/general/Cut16.gif
        toolbarButtonGraphics/general/Cut24.gif
        toolbarButtonGraphics/general/Help16.gif
        toolbarButtonGraphics/general/Help24.gif
        toolbarButtonGraphics/general/Import16.gif
        toolbarButtonGraphics/general/Import24.gif
        toolbarButtonGraphics/general/New16.gif
        toolbarButtonGraphics/general/New24.gif
        toolbarButtonGraphics/general/Open16.gif
        toolbarButtonGraphics/general/Open24.gif
        toolbarButtonGraphics/general/Paste16.gif
        toolbarButtonGraphics/general/Paste24.gif
        toolbarButtonGraphics/general/Properties16.gif
        toolbarButtonGraphics/general/Properties24.gif
        toolbarButtonGraphics/general/Remove16.gif
        toolbarButtonGraphics/general/Remove24.gif
        toolbarButtonGraphics/general/Save16.gif
        toolbarButtonGraphics/general/Save24.gif
        toolbarButtonGraphics/general/SaveAll16.gif
        toolbarButtonGraphics/general/SaveAll24.gif
        toolbarButtonGraphics/general/SaveAs16.gif
        toolbarButtonGraphics/general/SaveAs24.gif
        toolbarButtonGraphics/general/Stop16.gif
        toolbarButtonGraphics/general/Stop24.gif
        toolbarButtonGraphics/navigation/Back16.gif
        toolbarButtonGraphics/navigation/Back24.gif
        toolbarButtonGraphics/navigation/Forward16.gif
        toolbarButtonGraphics/navigation/Forward24.gif

        Show
        DM Smith added a comment - It would be good to get vector graphics for these and convert that to images so that we can have appropriate sized images. The description of the icons is here: http://java.sun.com/developer/techDocs/hi/repository/ Here is a listing of what Bible Desktop: (Note: cut and paste are not currently used, but are referenced in comments for future menu items.) toolbarButtonGraphics/general/About16.gif toolbarButtonGraphics/general/About24.gif toolbarButtonGraphics/general/ContextualHelp16.gif toolbarButtonGraphics/general/Copy16.gif toolbarButtonGraphics/general/Copy24.gif toolbarButtonGraphics/general/Cut16.gif toolbarButtonGraphics/general/Cut24.gif toolbarButtonGraphics/general/Help16.gif toolbarButtonGraphics/general/Help24.gif toolbarButtonGraphics/general/Import16.gif toolbarButtonGraphics/general/Import24.gif toolbarButtonGraphics/general/New16.gif toolbarButtonGraphics/general/New24.gif toolbarButtonGraphics/general/Open16.gif toolbarButtonGraphics/general/Open24.gif toolbarButtonGraphics/general/Paste16.gif toolbarButtonGraphics/general/Paste24.gif toolbarButtonGraphics/general/Properties16.gif toolbarButtonGraphics/general/Properties24.gif toolbarButtonGraphics/general/Remove16.gif toolbarButtonGraphics/general/Remove24.gif toolbarButtonGraphics/general/Save16.gif toolbarButtonGraphics/general/Save24.gif toolbarButtonGraphics/general/SaveAll16.gif toolbarButtonGraphics/general/SaveAll24.gif toolbarButtonGraphics/general/SaveAs16.gif toolbarButtonGraphics/general/SaveAs24.gif toolbarButtonGraphics/general/Stop16.gif toolbarButtonGraphics/general/Stop24.gif toolbarButtonGraphics/navigation/Back16.gif toolbarButtonGraphics/navigation/Back24.gif toolbarButtonGraphics/navigation/Forward16.gif toolbarButtonGraphics/navigation/Forward24.gif
        Hide
        Chris Burrell added a comment -

        as far as Maven goes, it won't matter to have an external jar file once we have a nexus repository... So if you're happy with it as is, then i wouldn't go changing it just for Maven

        Show
        Chris Burrell added a comment - as far as Maven goes, it won't matter to have an external jar file once we have a nexus repository... So if you're happy with it as is, then i wouldn't go changing it just for Maven
        Hide
        DM Smith added a comment -

        Chris, it's not an issue with maven. We've had several suggestions for improved images. Usually, it is simply a matter of personal preference.

        This really is part of a bigger desire:

        Couple of goals:

        1. better looking icons, having a consistent look & feel
          We have a couple of icons (e.g. blur 1, blur 5, the "Book" icons) that are ugly.
        2. icons which are understandable in an international context
          The book icons are a letter corresponding to an English word for the category of books. (I think we have an open issue for this one.)
        3. icons which can be easily be replaced by a user
          By using a standard naming convention e.g. http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html
          we can allow for a user to drop the set into ~/.jsword and have it replace the ones on the app. An example of this would be the Tango icons for Gnome/KDE. And if such a set were installed by the user on their machine (e.g. Linux) as a theme, then it'd be nice to use it.
        4. As monitor resolutions increase, the apparent size of the icons decreases. It'd be nice to allow for or be ready for "device independence".
        Show
        DM Smith added a comment - Chris, it's not an issue with maven. We've had several suggestions for improved images. Usually, it is simply a matter of personal preference. This really is part of a bigger desire: Couple of goals: better looking icons, having a consistent look & feel We have a couple of icons (e.g. blur 1, blur 5, the "Book" icons) that are ugly. icons which are understandable in an international context The book icons are a letter corresponding to an English word for the category of books. (I think we have an open issue for this one.) icons which can be easily be replaced by a user By using a standard naming convention e.g. http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html we can allow for a user to drop the set into ~/.jsword and have it replace the ones on the app. An example of this would be the Tango icons for Gnome/KDE. And if such a set were installed by the user on their machine (e.g. Linux) as a theme, then it'd be nice to use it. As monitor resolutions increase, the apparent size of the icons decreases. It'd be nice to allow for or be ready for "device independence".
        Hide
        Douglas Campos added a comment -

        what about using crystal icons from kde? their license is compatible with ours - it's not vectorial but have several sizes available

        Show
        Douglas Campos added a comment - what about using crystal icons from kde? their license is compatible with ours - it's not vectorial but have several sizes available
        Hide
        DM Smith added a comment -

        I'm partial to the Tango Icon Library (http://tango.freedesktop.org) for a couple of reasons.

        • They follow a standard naming convention.
          • This would require a one-time change to new names in the program.
          • Creates a loose coupling between program and icons. JSword would not be dependent upon icons, but applications using JSword would need to provide one.
          • This would allow for a user to drop in a replacement jar of icons.
        • They are in SVG along with various png sizes.
          • W/ SVG we can create other sizes as needed, such as for high resolution displays.
        • They look less obtrusive, stand-out than the Crystal.
        • The icons are in the public domain.
          • Importantly, this allows us to re-license JSword for Bible Societies, if we ever need to. Having 3-rd party LGPL Crystal icons restricts us from doing that.

        On a related note, I think it probably would be good to remove the icons from entries in the menu.

        Show
        DM Smith added a comment - I'm partial to the Tango Icon Library ( http://tango.freedesktop.org ) for a couple of reasons. They follow a standard naming convention. This would require a one-time change to new names in the program. Creates a loose coupling between program and icons. JSword would not be dependent upon icons, but applications using JSword would need to provide one. This would allow for a user to drop in a replacement jar of icons. They are in SVG along with various png sizes. W/ SVG we can create other sizes as needed, such as for high resolution displays. They look less obtrusive, stand-out than the Crystal. The icons are in the public domain. Importantly, this allows us to re-license JSword for Bible Societies, if we ever need to. Having 3-rd party LGPL Crystal icons restricts us from doing that. On a related note, I think it probably would be good to remove the icons from entries in the menu.
        Hide
        Douglas Campos added a comment -

        nice, I didn't knew tango-project - seems like a perfect fit

        Show
        Douglas Campos added a comment - nice, I didn't knew tango-project - seems like a perfect fit

          People

          • Assignee:
            DM Smith
            Reporter:
            DM Smith
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated: