<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 21, 2017 at 6:10 PM, Jaak Ristioja <span dir="ltr"><<a href="mailto:jaak@ristioja.ee" target="_blank">jaak@ristioja.ee</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span>On 21.12.2017 15:08, Troy A. Griffitts wrote:<br>
> Regarding the <div></div> for lg, an empty div usually is rendered with<br>
> no height but does induce a line break, by default. I didn't want to<br>
> force additional vertical whitespace, in the event there was already a<br>
> new line. Specifically in this case, this pushes a <div></div> into the<br>
> preverse material if the verse starts with lg or l. This cleans up<br>
> printing a verse number and then immediately a new line after the verse<br>
> number, which doesn't look nice.<br>
<br>
</span>I didn't understand what you just said, but maybe this should be amended<br>
to the code comment in OSISXHTML::MyUserData::outputN<wbr>ewline() which<br>
currently seems to imply that a regular newline character ('\n') should<br>
be amended, and not a "<div></div>".<br>
<br>
Secondly, does the "<div></div>" pass the testsuite*? It doesn't pass<br>
the osis_* tests in Sword++, which I believe are in sync with Sword.<br>
<br>
J<br>
<br>
<br>
* I'd run the testsuite in Sword SVN myself, but I can't figure out how<br>
to do it (using CMake, because using autotools is way too complex for me).<br></blockquote><div><br></div><div>The CMake tools do not properly execute "make test" since diatheke was moved to build in its own directory instead of inside of the "utilities" directory directly. The testsuite relies on the location of the diatheke binary for some of its execution. CMake lands that file at utilities/diatheke whereas the Autotools build puts it at utilities/diatheke/diatheke. In order to properly update this, I will need to add a new CMakeLists.txt file to the utilities/diatheke source directory. That requires more elevated permissions than simply updating the existing CMakeLists.txt file, which is a permission I already have. This is next on the priority list for me after I get the 1.8.0 release done (the tarball has been cut and uploaded, but there was a hiccup with the server config - that has been sorted and I just need to re-execute the deployment now).</div><div><br></div><div>As such, I need to bake up a proper patch file and submit it to Troy. Since I only discovered the CMake-related failure a few days ago myself, I haven't yet baked up that patch. According to Jenkins, however, which runs the testsuite at the end of the autotools build, the suite does not pass in the master branch: <a href="http://ci.crosswire.org/blue/organizations/jenkins/SWORD%20ci/detail/master/35/pipeline/36">http://ci.crosswire.org/blue/organizations/jenkins/SWORD%20ci/detail/master/35/pipeline/36</a> nor in the 1.8.0 branch: <a href="http://ci.crosswire.org/blue/organizations/jenkins/SWORD%20ci/detail/1.8/13/pipeline">http://ci.crosswire.org/blue/organizations/jenkins/SWORD%20ci/detail/1.8/13/pipeline</a></div><div><br></div><div>--Greg </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
______________________________<wbr>_________________<br>
<div class="gmail-m_4389243230859322145gmail-m_-1922737689128480727HOEnZb"><div class="gmail-m_4389243230859322145gmail-m_-1922737689128480727h5">sword-devel mailing list: <a href="mailto:sword-devel@crosswire.org" target="_blank">sword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/sword-devel" rel="noreferrer" target="_blank">http://www.crosswire.org/mailm<wbr>an/listinfo/sword-devel</a><br>
Instructions to unsubscribe/change your settings at above page<br>
</div></div></blockquote></div><br></div></div>