<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Jan 20, 2013 at 3:43 AM, Jonathan Morgan <span dir="ltr"><<a href="mailto:jonmmorgan@gmail.com" target="_blank">jonmmorgan@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi Greg,<br><br><div class="gmail_quote"><div class="im">On Sun, Jan 20, 2013 at 3:52 AM, Greg Hellings <span dir="ltr"><<a href="mailto:greg.hellings@gmail.com" target="_blank">greg.hellings@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div>On Sat, Jan 19, 2013 at 10:28 AM, Troy A. Griffitts <span dir="ltr"><<a href="mailto:scribe@crosswire.org" target="_blank">scribe@crosswire.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">I've done my part and changed one more tag. transChange has been upgraded from:<br>
<i></i><br>
<br>
to:<br>
<br>
.transChangeSupplied {<br>
font-style: italic;<br>
}<br>
<br>
<span class="transChangeSupplied"></<u></u>span><br>
<br>
More changes welcome.<br>
<br>
Nic, you mentioned doing similar work on your own copies of our filters. Any experience you'd like to share?<br>
<br>
Bibletime, same. I know you guys have had stuff styled for quite some time.<br></blockquote><div><br></div></div><div>BT outputs the following (found on lines 383ff of src/backend/filters/osistohtml.cpp):</div><div>
<span class="transchange"><span class="**type**"> ...... </span></span></div><div><br></div><div>where **type** is the value of the type attribute of transChange. If no type attribute is specified, the value of the changeType attribute is used. If the type or changeType attribute of transChange is equal to "added" then the outer span gets a title="Added text" and if it is equal to "tenseChange" it gets a title="Verb tense changed" added to it.</div>
</div></div></div></blockquote></div><div><br>Would you really want a title to be output for this? It seems very specific markup, quite different from the "class based" markup, and also raises the questions "How do we change the text displayed for a transChange?</div>
</div></blockquote><div><br></div><div style>I'm thinking we may have gotten our wires crossed in that line. The title is not instead of the class but in addition to. So a <transChange type="tenseChange"> is replaced with <span class="transchange" title="Verb tense changed"><span class="tenseChange">**textual content of original**</span></span></div>
<div style><br></div><div style>So the CSS still works as intended. Granted, you can set CSS selectors on arbitrary attributes with XPath-inspired syntax if you have a new enough rendering engine, which both BibleTime and Xiphos have at this time. Based on the code, I'm guessing this handling was originally limited to only added and tenseChange and later people just got a little lazy with it and didn't add in those titles.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="gmail_quote"><div> Or translate it? </div>
</div></blockquote><div><br></div><div style>It's translated the same way every other UI string in BibleTime is translated.</div><div style><br></div><div style><div> buf.append("<span class=\"transchange\" title=\"");</div>
<div> buf.append(QObject::tr("Verb tense changed").toUtf8().constData());</div><div> buf.append("\"><span class=\"tenseChange\">");</div></div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="gmail_quote"><div>Or show it in some other way than a tooltip?"<br>
</div></div></blockquote><div><br></div><div style>At least in the QtWebKit bindings, you can listen in on mouseover/hover events and pull out the text of the elements to display it however you want.</div><div style><br></div>
<div style>Also, to be clear, I wasn't suggesting that this BT code is /the way to go/, I was just answering Troy's question about how do those frontends which customize their HTML renderers handle the transChange element by telling him what the BT code does for the sake of comparison and discussion.</div>
<div style><br></div><div style>--Greg</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="gmail_quote">
<div>
<br>Jon<br> <br></div><div class="im"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra">
<div class="gmail_quote">
<div><br></div><div>Only some of our styles have CSS associated with the .transchange, but those which do have font-style=italic.</div><div><br></div><div>Looking at the particular C++ code, I see a very straightforward simplification we could do for it, so I'll probably simplify that logic down.</div>
<span><font color="#888888">
<div><br></div><div>--Greg</div></font></span><div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Would ultimately like to get this filter set to something we all can share and improve.<br>
<br>
Troy<br>
<br>
<br>
<br>
______________________________<u></u>_________________<br>
sword-devel mailing list: <a href="mailto:sword-devel@crosswire.org" target="_blank">sword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/sword-devel" target="_blank">http://www.crosswire.org/<u></u>mailman/listinfo/sword-devel</a><br>
Instructions to unsubscribe/change your settings at above page<br>
</blockquote></div></div><br></div></div>
<br>_______________________________________________<br>
sword-devel mailing list: <a href="mailto:sword-devel@crosswire.org" target="_blank">sword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/sword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/sword-devel</a><br>
Instructions to unsubscribe/change your settings at above page<br></blockquote></div></div><br>
<br>_______________________________________________<br>
sword-devel mailing list: <a href="mailto:sword-devel@crosswire.org">sword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/sword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/sword-devel</a><br>
Instructions to unsubscribe/change your settings at above page<br></blockquote></div><br></div></div>