<div>I object (luke-warmly). Cross-references are (in the ESV) tied to the word in front. If you put a space in, you can't tell which word (before or after) it is tied to.</div>
<div> </div>
<div>Surely this can be fixed in Xiphos? :D<br><br clear="all">God Bless,<br>Ben<br>-------------------------------------------------------------------------------------------<br>Multitudes, multitudes,<br> in the valley of decision!<br>
For the day of the LORD is near<br> in the valley of decision.<br><br>Giôên 3:14 (ESV)<br> </div>
<div><span class="gmail_quote">On 14/04/2009, <b class="gmail_sendername">Matthew Talbert</b> <<a href="mailto:ransom1982@gmail.com">ransom1982@gmail.com</a>> wrote:</span>
<blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">Does anyone have an objection to the following patch? It simply adds a<br>space between *x or *n and the following word. The lack of a space<br>
causes problems with Xiphos "click to look up a word". The only module<br>that I know that it affects is the ESV as the majority of the modules<br>put the crossrefs and footnotes at the end of the words. It is only a<br>
single normal space (as opposed to &nbsp;) so it should have no effect<br>if there happen to be two spaces. The RTF filter already does this.<br><br>To be technically correct, I suppose the other filters should have the<br>
same change, although I've never seen a module that put the crossrefs<br>immediately in front of the word except ESV.<br><br>Matthew<br><br>Index: osishtmlhref.cpp<br>===================================================================<br>
--- osishtmlhref.cpp (revision 2322)<br>+++ osishtmlhref.cpp (working copy)<br>@@ -246,7 +246,7 @@<br> SWCATCH ( ... ) { }<br> if (vkey) {<br>
//printf("URL = %s\n",URL::encode(vkey->getText()).c_str());<br>- buf.appendFormatted("<a<br>
href=\"passagestudy.jsp?action=showNote&type=%c&value=%s&module=%s&passage=%s\"><small><sup>*%c</sup></small></a>",<br>+ buf.appendFormatted("<a<br>
href=\"passagestudy.jsp?action=showNote&type=%c&value=%s&module=%s&passage=%s\"><small><sup>*%c</sup></small></a><br>",<br> ch,<br>
URL::encode(footnoteNumber.c_str()).c_str(),<br> URL::encode(u->version.c_str()).c_str(),<br>
@@ -254,7 +254,7 @@<br> ch);<br> }<br> else {<br>- buf.appendFormatted("<a<br>
href=\"passagestudy.jsp?action=showNote&type=%c&value=%s&module=%s&passage=%s\"><small><sup>*%c</sup></small></a>",<br>+ buf.appendFormatted("<a<br>
href=\"passagestudy.jsp?action=showNote&type=%c&value=%s&module=%s&passage=%s\"><small><sup>*%c</sup></small></a><br>",<br> ch,<br>
URL::encode(footnoteNumber.c_str()).c_str(),<br> URL::encode(u->version.c_str()).c_str(),<br>
@@ -268,7 +268,7 @@<br> if (tag.isEndTag()) {<br> u->suspendTextPassThru = (--u->suspendLevel);<br> u->inXRefNote = false;<br>- u->lastSuspendSegment = ""; // fix/work-around for nasb<br>
devineName in note bug<br>+ u->lastSuspendSegment = ""; // fix/work-around for nasb<br>divineName in note bug<br> }<br> }<br><br>_______________________________________________<br>
sword-devel mailing list: <a href="mailto:sword-devel@crosswire.org">sword-devel@crosswire.org</a><br><a href="http://www.crosswire.org/mailman/listinfo/sword-devel">http://www.crosswire.org/mailman/listinfo/sword-devel</a><br>
Instructions to unsubscribe/change your settings at above page<br></blockquote></div><br>