[sword-devel] breakage in verse management at -r2785?

Troy A. Griffitts scribe at crosswire.org
Thu Mar 21 16:26:19 MST 2013


Thanks Karl, 

Yes, each snippet was helpful. Nic's was a quick test which caused the bug and was easy to use for testing. Greg's snippet wasn't as helpful as all his comments and stack traces leading up to his patch. He is preventing book from getting to 0 which does alleviate the problem but also stops a book from becoming an intro. Hope that explains.

Troy 

Karl Kleinpaste <karl at kleinpaste.org> wrote:

>You didn't also need this snippet from Greg a couple days ago?
>
>--- src/keys/versekey.cpp	(revision 2792)
>+++ src/keys/versekey.cpp	(working copy)
>@@ -1347,7 +1347,9 @@
> 			}
> 			if (verse < (intros?0:1)) {
> 				if (--chapter < (intros?0:1)) {
>-					--book;
>+					if (book > 1) {
>+						--book;
>+					}
> 					chapter += (getChapterMax() + (intros?1:0));
> 				}
> 				verse += (getVerseMax() + (intros?1:0));
>
>_______________________________________________
>sword-devel mailing list: sword-devel at crosswire.org
>http://www.crosswire.org/mailman/listinfo/sword-devel
>Instructions to unsubscribe/change your settings at above page

-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.crosswire.org/pipermail/sword-devel/attachments/20130322/6c1540d1/attachment.html>


More information about the sword-devel mailing list