[sword-devel] Patches to fix compiler warnings

[Troy A. Griffitts]

Jaak,

I've partially applied this patch:

sword-Wunused-parameter-fix.diff.bz2

I agree that we should safely suppress the warnings in headers for empty 
virtual methods.   These are the hunks I applied.  The other warnings in 
the cpp files should be looked at individually to determine why the 
parameters are ignored and probably commented before the (void)param. I 
appreciate you going through all these files. When I was reviewing the 
patch, it showed me how useful some of these warnings can be.

Troy


On 12/21/2012 12:32 AM, Jaak Ristioja wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hello!
>
> Please apply these patches (bzip2-ed to workaround sword-devel 90 KB
> message size limit and attached) to fix about 3000 compiler warnings
> with GCC and Clang.
>
> The patches should apply to https://crosswire.org/svn/sword/trunk@2751
>
> Blessings,
> Jaak
>
>
> PS: Here are the sha1sums:
>
> 7ba3a0b954b8b545d407eb0f46821e4ebdb1c3bf  sword-Wempty-body-fix.diff.bz2
> e47776b086c1d8f686a09114bd162358db18a062
> sword-Wmissing-field-initializers-fix.diff.bz2
> fc68490a4aac0b8954fa02f0832fdccf95573fd7  sword-Wtype-limits-fix.diff.bz2
> eb2749fe94fcb8018be61c8925a12b2503460ac0
> sword-Wunused-parameter-fix.diff.bz2
> 004fbd6ac5bf6107cf37beb4b436f34400ec2774
> sword-comparison-not-assignment-fix.diff.bz2
> df8231f927ae1c34160b57d7b2a90e58a686448f
> sword-illegal-source-file-encoding.diff.bz2
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.19 (GNU/Linux)
>
> iQgcBAEBAgAGBQJQ05/3AAoJEEqsYmEt1rCON2E//ArXCLZm2Mv0ERKpAoGTvDi+
> JHOOaTf7JW42DkloDiPqMbOSYyLBAbuyJQUp0cFg9pQWTe2TpGu5Fr5n46hsKYSc
> FgFTM1fhVqimfeNt74425mxWKG9/DxuXskTI9MXLg6TwN/rVxr8kJpwqrYLnPy9C
> 118zyvKCO0YBGAhGx1lkQXmpZbDAvzFszWD9lTHdknDJ/OhMZ12kjmAcpkzraPJ0
> H/KhWGxyGm2mlJ7HuBpKyhVz7oUO7kYBrj9CCBpQwnB17rOCglLqbRLodZIPnd30
> ufL8YjAlwpDvhcIW7CiwaBq23xUjOefReKoAJ6TOw4CQ6AqWvTADj0T/509QoUKg
> ZfHBA0vQU0zxI4i67jmt86fI/2X3LuXNBdB9E+0wCLPxgVLuQImw3BufGdupkYe+
> Y3WddcRhtkWh/1yNhxBcB6hZoDZWTWs2iz4pIJYeO40pN6UZKC1MXLoAWqbufMfS
> eN0sWDcC7cadq0hkgNLWkWe1fxPfdSwrWgOjICas44elCASBtnjOub9zWhh/HdOB
> 668wCQtgBUo0ICdpdNAnsvIQiOhf60sgd99zvwczPeGgJKjvURzK/W4nS9UbwpUE
> JESZfeQnLdOWJ2u+THozFLnjoOCw9c5NMZrFhGodVVb/u0bPQzyJ0Z1pT5/BZnOX
> 1WC5PuQvGTBx/zepoLAuDLmh+SDqAhVm96fNTvhefY6oq78oQb+aG3N/mq64scXS
> S+42S/BJWjDlz21AbfQJprkLOL3DbPBHOxG4/KdF8TFo73iNeTsPfLveumDbn6MS
> DUwZETBZdOiGCLuBgmj9GIp/lMmQktdPJHv1JkdoLj+kL23oKR0MdvX5i+4rWOk/
> hs9D8JNCb+0bST71PUIW1HkF3elEYfZO/ciZ0U4mQVFFX/4VzXGJJqf5dh9HhCBZ
> 3N1srhXGw4GEEblUv0oT2q+czeSDCjs/zLFQ7ONzbT9qoLOhEbI3cJ89A8hRbSC7
> 3u9OXKjyvJPWQvALxCu90QeS0ygqJPK/JZcHyc7I5J7m61SwhuPU7axKsRTGpHuT
> X15w3SwaOz+P+r+WzRPj2OIcihBb4jnf+esk6ows7mNGa3jbm+UsGy/t2i5nb/p+
> DDoSnbxfTTpg9S9KOOrp6mTIZ9voCLXQAkEnx0E/1wu5xTgWI7aSSrXf5eO2JawP
> riWTK9EaQ/yUf0SXhVsFKB948ATdoX45ag9OJfR1ShU27qaEE8BBgfGzXjYgcd/o
> YujHVNhHfUD1xS8BF4D3G3LoO+l9m4d/iNtnXpc4JPd6f6ZuRGhKiM8V3N7olYYC
> 3Xf4hX9V4S2txrPX0XXG5Zq4x90Jx8VxbjN1UKMjTKRgfhghh4c0EzVvpq47sF7z
> qtULiOLlbEPUlH78nTu8eZ4Vy1DFhG2BEOSzWZatvO4UxiioewnQtp987ZG7Cpzy
> I2RRqrL4vv4FQ2UvOCEqVwYuZTSckcG18Bfy9FjqzH6WW/idBBUzWDrOgcEnke34
> 0A+hQtNo8+WMKD9zBdGEGY8ymNk/lj7F2JAvEhvvdXYemsDBiVfrezCj7EA7ybZp
> c8Oisk+EZgo4FMV49ytnjWR1rlsS7wCtLJb1GLjWOggIesrNq8rg9P7j8/u3U/GZ
> HDj/UsxInZcZv91u60r8oEl90vdP3hXJxdowKXjRBODFBmfQkJTFYoPd1JIOqyvT
> 1eGoYZ/o6ClGbEwcg8XEMOo2MvoF889b/yOOjP6kPt/tQUviwug2McU/KmNThqvU
> Arw/+8c/XpW/69SOHIBzgSS1ipcjOafn4k5g8bgkRknx97FaBBQNG9AqYl0iHlMS
> LwT9n6gPPBp3lF9LSWlzPvh0+vMQKfH4cwuIQMGwzhd156OkfYmfskoBCDv3VDhh
> mhhH502LOleMfoHajzo2IXc2IFToVxZq8rwhWwipXmEoOIH9DpbaaRwgbSjXQr72
> xerD7lzChmTqriH3TmhLXIe5IGpLhPJZOw4AMyuTC3IVvSvMyE4SX/9UHOvxHB3v
> sI9OfimIn2NCfsbxLI+0SI8cw7BlSHE63OJjp7yG7oVqbLL7T8VqK5uTgAHWuy16
> HebEXEs5yJtiSh1s2BQX5qxIOs9IFORBtgVlaTFozaVDMk+HMhHSN+pxb49vel0P
> ME7AOf1zIxqs1zFeZuqCRRzT8z3UoWcbu5maluSDyyI08i+1nzKDvRMW+77UrAWD
> 6sQD+JrHDQoUK8fu3OtUbUaOSyLW5bJ5+MeHEnsPrgvxC+B2lZYw9Bz5QCUSs6xu
> FhC7N1OlfM8b+e0EE0IAD2nwTvl0IcJFgbFMEm6KIy2dA6ChoPkTSbi3l0Nm2y7r
> iX57mdzKrgcRfUXkFWTrfDx8951qQpw16HNjwCa0zgNbrvKbEFqPzvEPzkNlWw0S
> E992keRPJNzpEXe9ZWZUE+qr92CsyqwAvPZ1z1jUT7swIKqrl7/O33CxiK2Iifoc
> BRV15T5V8LzWiO0MgOb85UsXZjwSxHMw8theHRAKvqKF0ti8ospgCirEU9ZTv7VF
> pSqFVOUBCgWkCtcGE8GaLg7eEleTx5inliILgD6kC+80CV8j1f3L6P2+zLMDxQeo
> W/cqdkbk8oL6yoOdRGMXuozPu3g7MQZUDYQplLxGcxYk3fDb2DKgiJw57Rlo+5ji
> O7I7wqWI88nEuku0wUIe11ydDSGtYGoOvRC0C4T/Z6vsvd/oNcQAb4tjrjqtKIlY
> OdqdFXYt+xF3RepeinW5
> =jSQt
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.crosswire.org/pipermail/sword-devel/attachments/20130129/496ee7d0/attachment.html>