[sword-devel] [PATCH] Unused code
Troy A. Griffitts
scribe at crosswire.org
Thu Mar 22 16:07:39 MST 2012
Thank you for the patches. I will review your patches again, but this
one specifically I would comment that I'm not in favor of removing
commented out code just to make distro checks pass. There is a reason
the code is still there, though commented out. I didn't write the URL
class, but would venture to thing that the intent was to eventually
support '#' mark, and code has been started but not completed.
Same with the isCommentary mark in osis2mod. I would guess that the
developers have plans to use that eventually to do special processing if
the text is a commentary text rather than a Bible text.
I'm excited about the other patches (besides the checking return values
patch which we disagreed on quite a number of months ago and I'll have
to dig up my reasons then, but rather than a theoretical reason, I
believe the patch at the time actually change the logic, which I was not
happy with the new results). And again, I believe these are all to make
a pedantic distro code checker happy, yes?
On 03/23/2012 12:00 AM, Dmitrijs Ledkovs wrote:
> Dear all,
> this patch simply removes some unused code.
> Reviews and comments are welcome.
> Please consider applying this to trunk or tell me why not.
> sword-devel mailing list: sword-devel at crosswire.org
> Instructions to unsubscribe/change your settings at above page
More information about the sword-devel