[sword-devel] Autotools Bug?

[Jonathan Marsden]

Matthew Talbert wrote:

> autogen.sh is (typically) a part of gnome, and is commonly used in
> gnome development, including xiphos. The autogen.sh in sword appears
> to more or less copy the functionality of gnome-autogen.sh. It is not
> needed with release packages, only for doing svn development.

Well, it (or an equivalent) is needed any time a developer needs to 
regenerate the build system, basically.  Sure.  That much I understand.

Can you explain *why* the script is needed for anything in SWORD, vs 
just using autoreconf instead?  SWORD has the GNU files NEWS, AUTHORS, 
COPYING, etc. so there is no issue with the default strictness setting 
that I can see (and if there were one, the more relaxed setting should 
be configured into configure.ac, not coded into a separate script, anyway).

Below is a (somewhat untested!) diff that allows autoreconf to work
for SWORD.  As you can see this is fairly trivial, adding two lines and 
changing one more.  Given this, is autogen.sh really "needed"?  Why?

Thanks,

Jonathan


diff -ur old/configure.ac new/configure.ac 

--- old/configure.ac    2009-05-04 16:33:28 -0700 

+++ new/configure.ac    2009-05-11 14:57:40 -0700 

@@ -15,6 +15,7 @@
 

  AM_CONFIG_HEADER(include/config.h) 

 

+AC_CONFIG_MACRO_DIR([m4]) 

 

  # 
--------------------------------------------------------------------- 

  # Check Programs 

diff -ur old/Makefile.am new/Makefile.am 

--- old/Makefile.am     2005-05-01 12:56:29 -0700 

+++ new/Makefile.am     2009-05-11 12:47:09 -0700 

@@ -8,6 +8,8 @@
 

  ##### Customizable stuff. Set it how you like it ##### 

 

+ACLOCAL_AMFLAGS = -I m4 

+ 

  # if building dll with gcc on windoze (www.mingw.org) 

  # note you must set need_local_regex and buildshare to yes 

  if MINGW 

diff -ur old/src/utilfuns/Makefile.am new/src/utilfuns/Makefile.am 

--- old/src/utilfuns/Makefile.am        2007-10-13 19:16:01 -0700 

+++ new/src/utilfuns/Makefile.am        2009-05-11 12:55:49 -0700 

@@ -1,7 +1,7 @@
 

  if HAVE_VSNPRINTF 

  else 

-CXXFLAGS += -DNO_VSNPRINTF 

+AM_CXXFLAGS += -DNO_VSNPRINTF 

  endif 

 

  utilfunsdir = $(top_srcdir)/src/utilfuns