[sword-devel] problems with osis filters?
mg.pub at gmx.net
Wed Dec 10 11:59:13 MST 2008
you are right, thanks for the hint.
Is this really the desired behaviour for the osisfootnotes filter, to leave out
the actual content?
Am Mittwoch 10 Dezember 2008 12:45:45 schrieb Ben Morgan:
> As I have noted before, when someone asked the same question, this was due
> to a change introduced in svn r2157 to osisfootnotes.cpp. You can still get
> at it through the EntryAttributes (which is what BPBible does now).
> However, this leaves the plain filters looking pretty bad at the moment
> when xrefs are turned on (they have empty brackets () in).
> On the 1.5.12 side, what I really want to see is a reasonably compatible
> release. A release without any dynamic versification code - there is a
> little too much code in BPBible which relies on the default versekey books
> being there (not to mention the SWIG wrappers... which currently don't
> compile against SVN). And I haven't got time to work on this - and won't
> for at least 2 months.
> God Bless,
>---------------- Multitudes, multitudes,
> in the valley of decision!
> For the day of the LORD is near
> in the valley of decision.
> Giôên 3:14 (ESV)
> On Wed, Dec 10, 2008 at 8:08 AM, Greg Hellings
<greg.hellings at gmail.com>wrote:
> > Martin,
> > On Tue, Dec 9, 2008 at 2:27 PM, Martin Gruner <mg.pub at gmx.net> wrote:
> > > Hi all.
> > >
> > > I've got problems with Sword 1.5.11, which seem not to be present with
> > 1.5.9.
> > > martin at workstation:/home/dev/sword/examples/cmdline$ ./lookup ESV "3Joh
> > 1:1"
> > > ==Raw=Entry===============
> > > III John 1:1:
> > > <title subType="x-preverse" type="section">Greeting</title><note n="a"
> > > osisID="3John.1.1!crossReference.a" osisRef="3John.1.1"
> > > type="crossReference"><reference osisRef="2John.1.1">2 John
> > > 1</reference></note>The elder to the beloved Gaius, <note n="b"
> > > osisID="3John.1.1!crossReference.b" osisRef="3John.1.1"
> > > type="crossReference"><reference osisRef="1John.3.18">1 John
> > 3:18</reference>;
> > > <reference osisRef="2John.1.1">2 John 1</reference></note>whom I love
> > > in truth. <lb type="x-end-paragraph"/> <lb type="x-begin-paragraph"/>
> > > ==Render=Entry============
> > > <a
> > href="passagestudy.jsp?action=showNote&type=x&value=1&module=ESV&passage=
> > > elder to the beloved Gaius, <a
> > href="passagestudy.jsp?action=showNote&type=x&value=2&module=ESV&passage=
> > > I love in truth. <br /><br />
> > > ==========================
> > >
> > > (Output from Sword SVN, seems to be same behaviour as 1.5.11)
> > >
> > > Please look at how the <reference> tags inside the <note> tag disappear
> > in the
> > > rendered output.
> > >
> > > At BibleTime, we use an OSISHTMLHREF descendant class for the filtering
> > of some
> > > tags. Now it seems that handleToken() does not even get called for the
> > > <reference> and </reference> tags. One call is for <note>, and the next
> > > already for </note>. Their content is skipped.
> > > This does not seem to be the case with Sword 1.5.9, but I could not
> > > find
> > out
> > > what causes this.
> > I observed some similar behaviors and took action to deal with a few
> > of the unhandled tags. I know there was an issue with note handling
> > in OSIS, but I'm not sure if that is in the patch I submitted the
> > other day or not. Troy or Chris said they'd hopefully get to it in
> > the next week. Adding support for the tags isn't usually very
> > difficult, provided there is a straightforward 1:1 mapping into
> > HTMLHREF. But I did make a few changes to some of the filters and if
> > there are other people making additions, it's probably time to at
> > least shuffle a 1.5.12 out the door, and maybe talk about naming it
> > 1.6 or something like that to incorporate the other changes?
> > --Greg
> > _______________________________________________
> > sword-devel mailing list: sword-devel at crosswire.org
> > http://www.crosswire.org/mailman/listinfo/sword-devel
> > Instructions to unsubscribe/change your settings at above page
More information about the sword-devel