[sword-devel] atches for new Module Driver RawCom4

Troy A. Griffitts scribe at crosswire.org
Tue Jul 31 14:13:07 MST 2007


Thank you for the patch!  I had just updated the comments on this bug:


and figured it would be best to keep backward compat, as you also suggest
and have done.  What timing! :)

Reviewing your patch, it looks good.  You had included some of the
experimental custom indexing code we had in rawtext.cpp, which I will likely
strip out, and reviewing the patch also reminded me that we have some silly
duplicated code which should also be isolated into a single place (prepText,
et. al.).

Thank you so much for taking the time research the necessary changes and to
produce a patch.  Wonderful!  Look for it to appear in svn shortly.


Doug Rintoul <doug_rintoul at sil.org> wrote: 
>A while back I ask about the ramifications of changing the data size for 
>commentary segments from unsigned short to unsigned long to overcome the 
>64K data limitation for commentary sections. I have had a closer look at 
>the code and decided it might be better to create a new module driver 
>than modify the existing driver. This way, there is no issues with 
>backward compatibility with existing  modules, and impact on the exist 
>code is minimal.
>I am attaching two patches, one for the sword library and one for 
>jsword. I followed the same approach as was taken for rawld4, and 
>rawtext4.  The patches are against sword-1.5.9 and the current svn 
>version of jsword. Would it be possible to include these patches in the 
>next release of sword and jsword?
>Please do not hesitate to ask question if more information is required.
>Doug Rintoul
>sword-devel mailing list: sword-devel at crosswire.org
>Instructions to unsubscribe/change your settings at above page

More information about the sword-devel mailing list