[sword-svn] r3239 - trunk/src/keys

[scribe at crosswire.org]

Author: scribe
Date: 2014-07-09 14:32:45 -0700 (Wed, 09 Jul 2014)
New Revision: 3239

Modified:
   trunk/src/keys/versekey.cpp
Log:
fixed clear error bug

Modified: trunk/src/keys/versekey.cpp
===================================================================
--- trunk/src/keys/versekey.cpp	2014-06-11 22:16:11 UTC (rev 3238)
+++ trunk/src/keys/versekey.cpp	2014-07-09 21:32:45 UTC (rev 3239)
@@ -157,7 +157,9 @@
 	}
 	else {
 		SWKey::positionFrom(*fromKey);
-		parse();
+// extraneous parse which inadvertently clears error flag
+// SWKey::positionFrom already calls copyFrom which calls setText, which VerseKey::setText already calls parse()
+//		parse();
 	}
 
  	// should we always perform bounds checks?  Tried but seems to cause infinite recursion
@@ -212,7 +214,9 @@
 	}
 	else {
 		SWKey::copyFrom(*fromKey);
-		parse();
+// extraneous parse which inadvertently clears error flag
+// SWKey::copyFrom already calls setText, which VerseKey::setText already calls parse()
+//		parse();
 	}
 }