[jsword-svn] jsword/java/jsword/org/crosswire/jsword/book/install s

jswordcvs at crosswire.org jswordcvs at crosswire.org
Sun May 8 18:29:11 MST 2005


Update of /cvs/jsword/jsword/java/jsword/org/crosswire/jsword/book/install
In directory www.crosswire.org:/tmp/cvs-serv6194/java/jsword/org/crosswire/jsword/book/install

Modified Files:
	InstallerEvent.java InstallManager.java 
Log Message:
Moved unused code to limbo.
Upgraded support-tools: checkstyle, pmd and findbugs to most recent.
Addressed over 100 issues reported by findbugs and checkstyle.
Resulted in major refactoring of GBFFilter.
Net result is that code size is significantly smaller.

Index: InstallerEvent.java
===================================================================
RCS file: /cvs/jsword/jsword/java/jsword/org/crosswire/jsword/book/install/InstallerEvent.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -C2 -d -r1.3 -r1.4
*** InstallerEvent.java	6 Mar 2005 20:21:47 -0000	1.3
--- InstallerEvent.java	9 May 2005 01:29:07 -0000	1.4
***************
*** 68,72 ****
       * The name of the changed Bible
       */
!     private Installer installer;
  
      /**
--- 68,72 ----
       * The name of the changed Bible
       */
!     private transient Installer installer;
  
      /**

Index: InstallManager.java
===================================================================
RCS file: /cvs/jsword/jsword/java/jsword/org/crosswire/jsword/book/install/InstallManager.java,v
retrieving revision 1.14
retrieving revision 1.15
diff -C2 -d -r1.14 -r1.15
*** InstallManager.java	15 Feb 2005 04:32:34 -0000	1.14
--- InstallManager.java	9 May 2005 01:29:07 -0000	1.15
***************
*** 55,62 ****
              factories = ClassUtil.getImplementorsMap(InstallerFactory.class);
  
!             for (Iterator it = sitemap.keySet().iterator(); it.hasNext(); )
              {
!                 String name = (String) it.next();
!                 String url = sitemap.getProperty(name);
  
                  try
--- 55,62 ----
              factories = ClassUtil.getImplementorsMap(InstallerFactory.class);
  
!             for (Iterator it = sitemap.entrySet().iterator(); it.hasNext(); )
              {
!                 Map.Entry entry = (Map.Entry) it.next();
!                 String url = (String) entry.getValue();
  
                  try
***************
*** 75,79 ****
                          Installer installer = ifactory.createInstaller(url);
  
!                         internalAdd(name, installer);
                      }
                  }
--- 75,79 ----
                          Installer installer = ifactory.createInstaller(url);
  
!                         internalAdd((String) entry.getKey(), installer);
                      }
                  }



More information about the jsword-svn mailing list