[jsword-svn] common/java/swing/org/crosswire/common/swing s

[jswordcvs at crosswire.org]

Update of /cvs/jsword/common/java/swing/org/crosswire/common/swing
In directory www.crosswire.org:/tmp/cvs-serv30532/java/swing/org/crosswire/common/swing

Modified Files:
	ExceptionPane.java CWAction.java MapCellRenderer.java 
	NumericDocument.java 
Log Message:
Update pmd ruleset.xml, adding new rules, (re)testing all rules, and cleaning up trivial reports.

Index: CWAction.java
===================================================================
RCS file: /cvs/jsword/common/java/swing/org/crosswire/common/swing/CWAction.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -C2 -d -r1.4 -r1.5
*** CWAction.java	24 Jan 2005 23:22:06 -0000	1.4
--- CWAction.java	19 Mar 2005 18:45:07 -0000	1.5
***************
*** 44,55 ****
  
      /**
-      * Create an empty action. This action needs to be populated in order to be useful.
-      */
-     public CWAction()
-     {
-         super();
-     }
- 
-     /**
       * Forwards the ActionEvent to the registered listener.
       * @param evt ActionEvent
--- 44,47 ----

Index: ExceptionPane.java
===================================================================
RCS file: /cvs/jsword/common/java/swing/org/crosswire/common/swing/ExceptionPane.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -C2 -d -r1.9 -r1.10
*** ExceptionPane.java	9 Mar 2005 02:25:57 -0000	1.9
--- ExceptionPane.java	19 Mar 2005 18:45:07 -0000	1.10
***************
*** 333,337 ****
          if (nex != null)
          {
!             retcode.append("<p><br><font size=\"-1\">" + Msg.CAUSED_BY + "</font>"); //$NON-NLS-1$ //$NON-NLS-2$
              retcode.append(getHTMLDescription(nex));
          }
--- 333,339 ----
          if (nex != null)
          {
!             retcode.append("<p><br><font size=\"-1\">"); //$NON-NLS-1$
!             retcode.append(Msg.CAUSED_BY);
!             retcode.append("</font>"); //$NON-NLS-1$
              retcode.append(getHTMLDescription(nex));
          }

Index: NumericDocument.java
===================================================================
RCS file: /cvs/jsword/common/java/swing/org/crosswire/common/swing/NumericDocument.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -C2 -d -r1.4 -r1.5
*** NumericDocument.java	6 Mar 2005 20:21:59 -0000	1.4
--- NumericDocument.java	19 Mar 2005 18:45:07 -0000	1.5
***************
*** 48,52 ****
          for (int i = 0; i < upper.length; i++)
          {
!             if (Character.isDigit(upper[i])) clear.append(upper[i]);
          }
  
--- 48,55 ----
          for (int i = 0; i < upper.length; i++)
          {
!             if (Character.isDigit(upper[i]))
!             {
!                 clear.append(upper[i]);
!             }
          }
  

Index: MapCellRenderer.java
===================================================================
RCS file: /cvs/jsword/common/java/swing/org/crosswire/common/swing/MapCellRenderer.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -C2 -d -r1.5 -r1.6
*** MapCellRenderer.java	6 Mar 2005 20:21:59 -0000	1.5
--- MapCellRenderer.java	19 Mar 2005 18:45:07 -0000	1.6
***************
*** 37,53 ****
  public class MapCellRenderer extends JTextArea implements TableCellRenderer
  {
!     /**
!      * Create a MapCellRenderer
!      */
!     public MapCellRenderer()
!     {
!         super();
!         // LATER(DM): wrapping requires the recomputation of row height.
!         // This would require grabbing wrapping events
!         // and for the MapTable to listen for them and to adjust row height.
!         // Not sure this is worth the effort.
!         // setLineWrap(true);
!         // setWrapStyleWord(true);
!     }
  
      /**
--- 37,53 ----
  public class MapCellRenderer extends JTextArea implements TableCellRenderer
  {
! //    /**
! //     * Create a MapCellRenderer
! //     */
! //    public MapCellRenderer()
! //    {
! //        super();
! //        // LATER(DM): wrapping requires the recomputation of row height.
! //        // This would require grabbing wrapping events
! //        // and for the MapTable to listen for them and to adjust row height.
! //        // Not sure this is worth the effort.
! //        // setLineWrap(true);
! //        // setWrapStyleWord(true);
! //    }
  
      /**