[jsword-svn] common/java/swing/org/crosswire/common/swing/desktop s

jswordcvs at crosswire.org jswordcvs at crosswire.org
Sat Mar 19 11:45:09 MST 2005


Update of /cvs/jsword/common/java/swing/org/crosswire/common/swing/desktop
In directory www.crosswire.org:/tmp/cvs-serv30532/java/swing/org/crosswire/common/swing/desktop

Modified Files:
	ToolBar.java 
Log Message:
Update pmd ruleset.xml, adding new rules, (re)testing all rules, and cleaning up trivial reports.

Index: ToolBar.java
===================================================================
RCS file: /cvs/jsword/common/java/swing/org/crosswire/common/swing/desktop/ToolBar.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -C2 -d -r1.3 -r1.4
*** ToolBar.java	6 Mar 2005 20:21:59 -0000	1.3
--- ToolBar.java	19 Mar 2005 18:45:07 -0000	1.4
***************
*** 92,98 ****
      public void showText(boolean show)
      {
-         Component c;
          int i = 0;
!         while ((c = getComponentAtIndex(i++)) != null)
          {
              if (c instanceof JButton)
--- 92,98 ----
      public void showText(boolean show)
      {
          int i = 0;
!         Component c = getComponentAtIndex(0);
!         while (c != null)
          {
              if (c instanceof JButton)
***************
*** 109,112 ****
--- 109,114 ----
                  }
              }
+             i++;
+             c = getComponentAtIndex(i);
          }
      }
***************
*** 118,124 ****
      public void showLargeIcons(boolean large)
      {
-         Component c;
          int i = 0;
!         while ((c = getComponentAtIndex(i++)) != null)
          {
              if (c instanceof JButton)
--- 120,126 ----
      public void showLargeIcons(boolean large)
      {
          int i = 0;
!         Component c = getComponentAtIndex(0);
!         while (c != null)
          {
              if (c instanceof JButton)
***************
*** 141,144 ****
--- 143,148 ----
                  }
              }
+             i++;
+             c = getComponentAtIndex(i);
          }
      }



More information about the jsword-svn mailing list