<p dir="ltr">Thanks for letting me know about verse 0 changes. I'll wait till you're done because step has special logic to work out whether something is the beginning of a chapter</p>
<div class="gmail_quote">On 17 Feb 2013 05:22, "DM Smith" <<a href="mailto:dmsmith@crosswire.org">dmsmith@crosswire.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Lots of changes to 35 files (including tests) in support of Alternate Versification.<br>
You can see it, play with it and comment on it at:<br>
<a href="https://github.com/crosswire/jsword/pull/35/files" target="_blank">https://github.com/crosswire/jsword/pull/35/files</a><br>
<br>
I've tried to make verse 0 not show up quite as much. So Chapter 0 and 1 are both considered as the start of a book. Likewise, verse 0 and 1 are the start of a chapter.<br>
<br>
This has an annoying side-effect. Two verse ranges may have the same "name" but be different internally. That is Gen 0:0-50:26, Gen 1:0-50:26 and Gen 1:1-50:26 are different but all have the name "Gen"<br>
<br>
Will work on that tomorrow.<br>
<br>
Together in His Service,<br>
DM<br>
<br>
On Feb 16, 2013, at 1:46 PM, DM Smith <<a href="mailto:dmsmith@crosswire.org">dmsmith@crosswire.org</a>> wrote:<br>
<br>
> I'm going to have to change Verse to take a versification. Was hoping not to do that.<br>
><br>
> The fundamental reason is that we have too much code that allows for Verse to be in a container that requires Verse to be Comparable.<br>
><br>
> I could do a brain dead ordering of book, chapter, verse. This works for chapter and verse, but not for book. Books are not ordered alphabetically, but in versification order.<br>
><br>
> Right now, compareTo is deprecated (to see what needs to change), but it also means that I'd have to remove "implements Comparable" as well.<br>
><br>
> Anyway, there's a patch for this in Jira and it passes all tests. Thanks John for the patch.<br>
><br>
> In Him,<br>
> DM<br>
> _______________________________________________<br>
> jsword-devel mailing list<br>
> <a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
> <a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
<br>
<br>
_______________________________________________<br>
jsword-devel mailing list<br>
<a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
</blockquote></div>