[jsword-devel] cleaner layout and UI ?

Willie Thean williethean at yahoo.com
Sun Aug 14 15:48:38 MST 2005


Hi DM --

Thanks for cleaning up and the instructions on
Eclipse. I'll see if I 
can do something similar with Netbeans next time
around.

Attached are the affected sources for now.

Thanks,
Willie

DM Smith wrote:

> Willie,
>     I've checked in the code. It looks good. I
cleaned up the 
> checkstyle complaints. Mostly removing whitespace at
the end of the 
> lines and adding whitespace around operators. Also
made changed 
> "public static int" to "public static final int"
since they should 
> never change. Renamed BaseLFCustoms to
AbstractLFCustoms. Moved member 
> variables to bottom of class. Added some javadoc.
And I added the LGPL 
> license to each of the files with you as the author.
>     The diffs would not apply. Either you can send
the changed files 
> or try the patch again. If you are using Eclipse,
you can go to 
> Synchronize view and for each package, right click
on it and choose 
> "Create patch...". In the dialog, save it to disk.
On the next screen, 
> check "Recurse into Subfolders" and "Include new
files in patch" and 
> choose "Unified (format required by the Apply
Patch)". Then click on 
> Finish. Because some mail readers wrap long lines
even for 
> attachments, zip up the patches.
>
> Thanks so much for pitching in,
>     DM
>
> Willie Thean wrote:
>
>>Hi DM --
>>
>>Attached is the source and diff files.. Let me know
if
>>it doesn't work. 
>>I can send all the affected  sources.
>>
>>Thanks,
>>Willie
>>
>>DM Smith wrote:
>>
>>  
>>
>>>Willie,
>>>    It looks good to me! If you wish either sent a
>>>    
>>>
>>unified patch 
>>  
>>
>>>against the source or send the source and I'll
>>>    
>>>
>>review and apply the 
>>  
>>
>>>changes. Probably would be best to zip it.
>>>Thanks!
>>>    DM
>>>
>>>Willie Thean wrote:
>>>
>>>    
>>>
>>>>Hi --
>>>>
>>>>I clean the layout and UI a little for Metal and
>>>>WindowsXP LookAndFeel 
>>>>(sorry I don't have a Mac). Put the attached 
>>>>BDModified.zip in front of 
>>>>the classpath and take a look.
>>>>
>>>>Thanks,
>>>>Willie
>>>>
>>>>
>>>>
>>>>		
>>>>____________________________________________________
>>>>Start your day with Yahoo! - make it your home
page 
>>>>http://www.yahoo.com/r/hs 
>>>>
>>>>
>>>>------------------------------------------------------------------------
>>>>
>>>>_______________________________________________
>>>>jsword-devel mailing list
>>>>jsword-devel at crosswire.org
>>>>http://www.crosswire.org/mailman/listinfo/jsword-devel
>>>> 
>>>>
>>>>      
>>>>
>>>------------------------------------------------------------------------
>>>
>>>_______________________________________________
>>>jsword-devel mailing list
>>>jsword-devel at crosswire.org
>>>http://www.crosswire.org/mailman/listinfo/jsword-devel
>>> 
>>>
>>>    
>>>
>>
>>
>>
>>
>>		
>>____________________________________________________
>>Start your day with Yahoo! - make it your home page 
>>http://www.yahoo.com/r/hs 
>> 
>>
>>------------------------------------------------------------------------
>>
>>_______________________________________________
>>jsword-devel mailing list
>>jsword-devel at crosswire.org
>>http://www.crosswire.org/mailman/listinfo/jsword-devel
>>  
>>
>------------------------------------------------------------------------
>
>_______________________________________________
>jsword-devel mailing list
>jsword-devel at crosswire.org
>http://www.crosswire.org/mailman/listinfo/jsword-devel
>  
>



__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: org.zip
Type: application/x-zip-compressed
Size: 30532 bytes
Desc: 2230628192-org.zip
Url : http://www.crosswire.org/pipermail/jsword-devel/attachments/20050814/7cd3b982/org-0001.bin


More information about the jsword-devel mailing list