<div dir="ltr"><div><div><div>I have stated to post merge requests at Gitorious.<br><br></div>Btw is it possible to rename <br>.src\backend\filters\osismorphsegmentation.h<br>.src\backend\filters\osismorphsegmentation.cpp<br>
</div><div>to something else<br></div><div><br></div>there is collision with Sword having the same object, gcc during compilation process creates one *.o file for two *.cpp files and i have missed symbol on ld.<br><br></div>
Blessings.<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/12/10 Jaak Ristioja <span dir="ltr"><<a href="mailto:jaak@ristioja.ee" target="_blank">jaak@ristioja.ee</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA1<br>
<br>
Hi λΟΣΤΡ!<br>
<br>
First of all thank you for all the great work you are doing on<br>
BibleTime mini!<br>
<br>
I took a quick look at your patches.<br>
<div class="im"><br>
On 09.12.2013 19:13, λΟΣΤΡ νΑΣΜΐΛ wrote:<br>
> Usage of QScopedPointer<> for QDir was required for Windows Mobile<br>
> only, because there was serious problems with static data<br>
> initialization order. Those changes just works on Windows and Linux<br>
> platforms, i have tested them with my own build scripts for desktop<br>
> BibleTime.<br>
<br>
</div>Was it another one of these "initialize a Qt object before<br>
QApplication" type of problems?<br>
<div class="im"><br>
> Also its better to use qputenv and qgetenv instead of actual<br>
> functions, because of lack of the last ones on some platforms. Not<br>
> sure if this works everywhere.<br>
<br>
</div>I'm unsure whether the function qunsetenv is available for earlier Qt<br>
versions. I found no documentation on it except for this rather new<br>
commit:<br>
<a href="https://qt.gitorious.org/qt/peter-hs-qtbase/commit/574e5cf9c510fb28781c8006a1184ca158ee859f" target="_blank">https://qt.gitorious.org/qt/peter-hs-qtbase/commit/574e5cf9c510fb28781c8006a1184ca158ee859f</a><br>
<br>
I think that at minimum we need to support Qt 4.8 so the patch might<br>
actually need some #if preprocessing stuff, e.g:<br>
<br>
#if QT_VERSION >= 0x050000<br>
#else<br>
#endif<br>
<br>
If you can make it work with Qt 4.8 also, then please file a merge<br>
request @ <a href="http://gitorious.org" target="_blank">gitorious.org</a> for review and then you can get the commit<br>
credits :)<br>
<div class="im"><br>
> The last, i have used mutexes for config core to avoid<br>
> simultaneous execution of some code. This quick solution helped me<br>
> to beat exception with my project, it should not break anything but<br>
> not sure if this is complete solution.<br>
<br>
</div>Yes, this does not seem to be a complete solution. It might work for<br>
your specific case, but not for everybody. The questions is what<br>
exactly does that mutex protect? If it ought to protect only<br>
m_settings, then all accesses to m_settings should be guarded by a<br>
respective lock. If the mutex ought to protect the entire class, all<br>
methods except the constructor and destructor should be guarded. A<br>
complete solution for this class would be needed.<br>
<br>
<br>
Blessings!<br>
Jaak<br>
-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v2.0.22 (GNU/Linux)<br>
<br>
iQgcBAEBAgAGBQJSpjMZAAoJELozJlbjIn79WwQ//RlJZi/21h26hI/nXR20GyIF<br>
0o2sFngviED3j3LH7EUGxd8d0QYB1Vni5cyMv1va8dRV3+RnsaTwA0xbeQt54GTF<br>
RW4l2See840rU/sj4D8QLd8aHWl4op+SSK9oQpoljZ4MWeWFdmWbVDa+oNePBqT/<br>
aAOZAPFFjqO2XXSPWm7nJ+ecMU+7mCwYOULMHxWDiJIjOGPMTJz3B3w4bkflRc+F<br>
aGMe32YSrcJRCdKuU+Tm49TZqsiCtcnm4S0kGeWj+y9XwYJ2mu0z3tyYwJyk2NEN<br>
Sz6cr0+DDaLl4qYWDfqrn1LqXH/fx7+Ra/xJkXKHhax6Fwm5SGpXtMoR3x3JTp2B<br>
4wWBIaJpmAiB8h5MOZOQI39lr2VZEzmcAdBE8Dw95xqgwvKUtB0JLrYm07dyKU4S<br>
6L/hvjALbhvXCdcUcpOZKKf8l2dK8JlCwN6jTUV0B1F9pK5fKFGaYLR7ii3ZqLhK<br>
Gv/VOj+jOkXOTjmdhITlr93dViOOQMl2dUa6kPGjjhNZouzjsGwr1ToEycbrGkPy<br>
co4mgOWUsVTTqYtRlQ8kteAtigKPRoI51tKoFL2e2UgSm6Fy7MctUGfZ89ItMY6G<br>
VaAnjiSFL5euPkGNblb8fK3TsWTuxUyQTkv29TZI4/ifrltRc7haTy5tcmdsZABY<br>
+d77H/kbrYii/KqByTht6wXZ7gg5/wO1TRbqUz9bH5jU2XrOC32eWNzrF2IgYbQX<br>
FDwy4mTtpiLNOQ1+6J0HLOTfbPgx4c0fM1+N482iY2M7FXLWIootTMLddiELJbEn<br>
KAUxD+Omoge2KelfkKd/Q8OqHDRnsVhkcq5qNRFmtb9EQ9H4dA6Zmzpm21ZK4FDt<br>
S8bMQBT7GhiSNsh1CW4fRMHcN1kSZa0EPdWZM9t4v8M9zTaao13qrmmA76rBpKyQ<br>
47QesDQT7knF0iRdl5pJWty2nXmPXmrnZvm9Zx6Is40Mdh1CLbM7QpfzW2VbnFOJ<br>
tZsCCK+DtD1jffKKMFRBWqTciKJoiEzZw3rVhoM8vKiRualvRoy98q88d+pOoPx9<br>
oGLq9Kjh20jnURp+bU45ukaUwJ8BwhT37xd90H9q0K3UCI2Ypc23jjm1+cf7Ou62<br>
JE/wU1/eEHeFWvs20SskfuGfTbHMVNs0aO/zO5aG7TZGE14H25W1G/HR7TsKSbD/<br>
dsYgvYQxeyKZbk6Vm55pdfGIXH2pIW2bKTN4aAH0IW9M+gvAc65D6XsR2ec2Tct7<br>
JT1t/I/jKH8tVVD8g5adADndv6Rudbtd8FirbydjooLd1IQF1xihfd/0ttoppUNO<br>
91GcX/XPjnt/b6y4GFVRSKpcYnC0QdDD5HVypvWSKHYTH1nuexIHsuqLMrsDaOLL<br>
kcYzCYY3IJwkYYEMHJrM5vQTgD+9rFasXvf8yhOHz2g/zfbenrJd+MdO/vyRSRZD<br>
HTttFDcUtbgWN+vsXizVmYjGdL7DkqQzXUQ9MjHsgk56X5i3JT/u+NTTP1re626F<br>
QbWiib3XfChOQVFmtvQ+9B5l/5Eqxs97Qu8pnuQpl3IuoOsrK/JapNsG19faHOx8<br>
PCiRo0tDtV8gemiUd1qPPfNv/HGSOV/3MSZVBmoVgPDmF7d1U3f1B8UMwRn86RPy<br>
ZoZkOJb8fd8NvEb/JxAvHDdu86g+eEfU4331Z6SvBa4TlJ10Bh5zRIzrbY4K1WSZ<br>
0+mwBYdG4sIHm646wUKLi0U5yIfcQpQkuO5yx21ys8d6AmshI9jpya/InYzfsjv1<br>
IfNS35OW6R9/ecMcFR+cwedKfALMGBQb3xDX56ELfCkvn/aECeZ6Oh86Zeoos14L<br>
ToaTQPbTvl3t33yLf6uCjhHcYjyYfEgkrbgzYUtLo7d/QZinPrJVfmUDwo66VCOW<br>
b6srIeLyZilmcS6hk/s9dLWt4k0kwo6d/JsELQPrLkcL1KEv995ooMDA6wcJpV3j<br>
1R291GYILZQAyzqUfoG90vDo5CKetRlLDjed5dyQ6DI7YLhm1E8gi8dzayp2ihRg<br>
K2RyYFnnyNZI2YwNCsWGbhf5PQAs7+NTc3B8Tq/7ZMYayjwPQGv4yIUqgFNgAOBh<br>
kxeLd5ji82jsQSkObjpTDQGhYlKU0hH/MEvZIlicidXDjNgLi6JdScuhUgkDXTPJ<br>
CvD/1K/q1y94l4cn6L0DHm+mT9sxx0HhWOu+M66JA+TkRX9HyuJS7xWeEgbSFp3z<br>
yBWY79WY2HBlAzp+vONbiDTfOGg/o33QPoo2xomSqEwIofetWmplt/OerPxBQzAi<br>
tIQYz6SdzqGU5KqM5DwXldRiwZ8bS8ntZosfROSGF156VI7aRKrwCXpCVgY2nMi1<br>
FinhKROWyVfdSLEbGFjDPHPzqaGHxaiXiO14/Y07aMWh0wNw8PEp9AmAX1K4gcJb<br>
YJDPiIwGTFm8bZqgF8pqRK0vmmqXA0Fd0M7Bqwub/GI1O8TCvp+Y60uL3WMpAnvQ<br>
XJoHHuExbZleBVVlVEHPwSKQOfvStf9u6oPcE2nXl1DWR7cFhrO09jxnRVGYDJGR<br>
LCIVC1mta2Jt+7qqNE8DU1rKNrT5GTAnrKa/vXr4cMhh1NK4Lx7gwFftAWgMF2d3<br>
LtyuKWyp7dFTRbX4znzwTdOTa9Lf2D79Vqt3S6cbshQKGhYchXqF7BKlOtN/5xMN<br>
kdFNNNnmHLEKpfNt18W4x5wcQNYYk16Jp425d06x+Ur/xT7sck/vTtDrW+iqCSu4<br>
1mm832JzxlyYF42ZSSrQ<br>
=4Xz0<br>
-----END PGP SIGNATURE-----<br>
<br>
_______________________________________________<br>
bt-devel mailing list<br>
<a href="mailto:bt-devel@crosswire.org">bt-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/bt-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/bt-devel</a><br>
</blockquote></div><br></div>