<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Jaak!<br>
<br>
Thank you very much for your recent commit regarding initBounds(),
this seems to fix the performance issues I had with the Bookshelf
Manager on MacOS! It would be great to have a new release with this
fix.<br>
<br>
QT 4.5 is minimum: SET(QT_MIN_VERSION 4.5.0) (from CMakeLists.txt).
We might think about raising this to introduce some other features
related to the JavaScript integration in future.<br>
<br>
I did not know that whitespace at the end of a line is a problem in
our sources?<br>
<br>
Regarding the bugs: I like the bug tracker at github.com. It feels
very natural. And github now also supports organizations. So maybe
moving the project there from gitourious would be an option? <br>
<br>
We use bugzilla at work, but it is quite technical. It does allow
for very fine-grained classifications etc. Depends on the main goal
of the bug tracker. Sourceforge offers Mantis as a hosted app...<br>
<br>
Best regards, mg<br>
<br>
Am 20.08.11 09:54, schrieb Jaak Ristioja:<br>
<blockquote type="cite">On 20.08.2011 06:22, Gary Holmlund wrote:<br>
> Jaak,<br>
<br>
> I was looking at the feature requests and saw that the
request to add<br>
> close buttons to tabs would be easy to do. I checked it in a
bit ago. I<br>
> did not realize that you had recently assigned it to yourself
until I<br>
> went to close it. I am sorry for not checking this first.<br>
<br>
> Gary<br>
<br>
Hi Gary!<br>
<br>
No problem. This is not high-priority thing anyway. Thanks you for
your<br>
contribution! :) I took a quick look at your commit, and I have a
few<br>
small questions/issues about this:<br>
<br>
* Are you sure the using findChildren() is ok? I mean it's
recursive and<br>
could match any QTabBar in the QObject chain. Maybe we should
explicitly<br>
use a QTabWidget for this MDI type.<br>
* setTabsCloseable was introduced in Qt 4.5. Can anybody recall
what was<br>
the minimum Qt version we require?<br>
* Do we really need to use disconnect() there?<br>
* Changelog entry had extra space at the end of line (git diff
printed<br>
it out RED)<br>
* #includes appear to be in non-alphabetical order (would be
easier to<br>
read imho).<br>
<br>
Feel free to express your opinion and argue with me :)<br>
<br>
<br>
Many blessings! :)<br>
Jaak<br>
<br>
<br>
PS: We should really consider setting up a better bug-tracker than
the<br>
one at SourceForge. I have a strong preference for Bugzilla
because my<br>
bug-reporting experience with projects like Gentoo Linux, Linux
Kernel,<br>
KDE, GNU GCC, RedHat etc have been mostly very positive with it.
It<br>
provides a lot better email notifications. I might try to setup
Bugzilla<br>
on my home server (just got a lot of more bandwidth) at some
point...<br>
</blockquote>
<span style="white-space: pre;">><br>
> _______________________________________________<br>
> bt-devel mailing list<br>
> <a class="moz-txt-link-abbreviated" href="mailto:bt-devel@crosswire.org">bt-devel@crosswire.org</a><br>
> <a class="moz-txt-link-freetext" href="http://www.crosswire.org/mailman/listinfo/bt-devel">http://www.crosswire.org/mailman/listinfo/bt-devel</a><br>
></span><br>
<br>
</body>
</html>