[bt-devel] Proposed change for BibleTime

[Gary Holmlund]

Jaak,

I have updated the mv2 branch on my BibleTime repository. I am about 
ready to merge into the main repository. It has the following features:

Continuously scrolling works windows across chapter and book boundaries. 
Page Up/Down keys can be used to move the text. Also, the scroll bar, 
mouse wheel, touchpad scrolling, etc. All of this works for all works 
types.

Auto scrolling of the active works window. Start scrolling with Shift-Up 
or Shift-Down. Increase speed by repeating Shift-Up/Down. Use the space 
bar to toggle the pausing. Hit any other key to completely stop. Also, 
changing the active window stops it. The shortcuts are in the main 
window group and can be changed using the Settings/Configure dialog.
Changed the Copy context menu to ask for the first and last key name 
that will copy to the clipboard. It can copy an entire book of the 
Bible, but it does have limit if the first and last are to far apart.

The Personal commentary can be viewed like any other work. Now you can 
mouse click a verse and a dialog appears to edit and save that verse. 
You no longer have to open a separate "write" window to edit the 
Personal commentary. This works even if the Personal commentary is part 
of a parallel view. I believe it works so well that the "write" window 
functionality should be removed.


All usage of QWebEngine has be removed. I would appreciate any comments 
about these features.

Since this represent a large change of code in BibleTime, it would not 
surprise me I have broken some feature. We will need a testing period.

Gary


On 09/20/2018 11:47 PM, Jaak Ristioja wrote:
> Hi, Gary!
>
> On 21.09.2018 05:25, Gary Holmlund wrote:
>> I wanted your approval before going any farther.
> Thank you for the update. You have my approval. As you have probably
> already noticed, I'm not currently a (very) active BibleTime developer,
> and I don't want to get in your way with things. So feel free to go
> ahead with this feature and merge/rebase to master when ready.
>
>
>> It is implemented for the "read" windows. Most features are implemented.
>> The main missing features now relate to the context menus (Find, copy,
>> etc.). These are not a problem to finish. They just require some more
>> time. Optionally we could eliminate all usage of QWebEngine by working
>> on the MAG view, the personal commentary editing, the search dialog, the
>> about dialog, etc.
> I compiled and ran BibleTime from your mv2 branch, and it looks good.
> One glitch I noticed is that the BtBibleKeyWidget did not update the
> location when I scrolled the view using the scrollbar.
>
> You might also want to think about improving scrolling with mouse, e.g.
> change the cursor to a grab cursor when the user can grab the document
> to scroll, perhaps implement some means for faster scrolling, and
> perhaps even automatic scrolling. For example, in Okular one can grab
> the document with the cursor and then scroll it with moving the cursor
> even up to the top or bottom edge of the screen beyond which scrolling
> continues so that the cursor appears at the opposite of the screen still
> holding the grab. Okular also has the nice feature of automatic
> scrolling, which can be toggled and incrementally acceleratedor
> decelerated by the Shift+Up or Shift+Down key combinations.
>
> J
>
> _______________________________________________
> bt-devel mailing list
> bt-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/bt-devel