[bt-devel] patches from mini

Tue Dec 10 14:31:12 MST 2013

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hmm... maybe this is same linking error people get on OS X.

I'll try to rename them.

Blessings,
Jaak

On 10.12.2013 12:59, Костя Маслюк wrote:
> I have stated to post merge requests at Gitorious.
> 
> Btw is it possible to rename 
> .src\backend\filters\osismorphsegmentation.h 
> .src\backend\filters\osismorphsegmentation.cpp to something else
> 
> there is collision with Sword having the same object, gcc during 
> compilation process creates one *.o file for two *.cpp files and i
> have missed symbol on ld.
> 
> Blessings.
> 
> 
> 2013/12/10 Jaak Ristioja <jaak at ristioja.ee
> <mailto:jaak at ristioja.ee>>
> 
> Hi Костя!
> 
> First of all thank you for all the great work you are doing on 
> BibleTime mini!
> 
> I took a quick look at your patches.
> 
> On 09.12.2013 19:13, Костя Маслюк wrote:
>> Usage of QScopedPointer<> for QDir was required for Windows
>> Mobile only, because there was serious problems with static data 
>> initialization order. Those changes just works on Windows and
>> Linux platforms, i have tested them with my own build scripts for
>> desktop BibleTime.
> 
> Was it another one of these "initialize a Qt object before 
> QApplication" type of problems?
> 
>> Also its better to use qputenv and qgetenv instead of actual 
>> functions, because of lack of the last ones on some platforms.
>> Not sure if this works everywhere.
> 
> I'm unsure whether the function qunsetenv is available for earlier
> Qt versions. I found no documentation on it except for this rather
> new commit: 
> https://qt.gitorious.org/qt/peter-hs-qtbase/commit/574e5cf9c510fb28781c8006a1184ca158ee859f
>
>  I think that at minimum we need to support Qt 4.8 so the patch
> might actually need some #if preprocessing stuff, e.g:
> 
> #if QT_VERSION >= 0x050000 #else #endif
> 
> If you can make it work with Qt 4.8 also, then please file a merge 
> request @ gitorious.org <http://gitorious.org> for review and then 
> you can get the commit credits :)
> 
>> The last, i have used mutexes for config core to avoid 
>> simultaneous execution of some code. This quick solution helped
>> me to beat exception with my project, it should not break
>> anything but not sure if this is complete solution.
> 
> Yes, this does not seem to be a complete solution. It might work
> for your specific case, but not for everybody. The questions is
> what exactly does that mutex protect? If it ought to protect only 
> m_settings, then all accesses to m_settings should be guarded by a 
> respective lock. If the mutex ought to protect the entire class,
> all methods except the constructor and destructor should be
> guarded. A complete solution for this class would be needed.
> 
> 
> Blessings! Jaak
> 
> _______________________________________________ bt-devel mailing
> list bt-devel at crosswire.org <mailto:bt-devel at crosswire.org> 
> http://www.crosswire.org/mailman/listinfo/bt-devel
> 
> 
> 
> 
> _______________________________________________ bt-devel mailing
> list bt-devel at crosswire.org 
> http://www.crosswire.org/mailman/listinfo/bt-devel
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQgcBAEBAgAGBQJSp4gaAAoJELozJlbjIn79buY/+wUJ/WSzcIqdrYRa/7suV04b
8TVjbJPB4ACbVWBsojyZvq3kvPqRM/vRbNY1/zVS4QyEWfyYV2bdzXQ8LCMqbzXk
OddSYD4Nr4wx9zUJUoC/QJOmaqv3WdENymV+5ZScmqZWnE+nwqZrXTPW7hv42SlT
wQOlS0GBlLtOhaPAEm0p8n/rTUGwmaKvkmyduzQsK6yk0rbeFd1oYeiMwt/GowV1
df7pSjZ5TMMs0YJI35yN2+AfV1nWdAdwEoqL3DcOwEcUCYOqXfjh5hqZj1u550Kq
HgS3tLK8DXMN9V+4L7fbSlS+F2tH7gGKCk/ur1fCrO/6+UIEsAQfYCnr9bP37QkG
EvyWA/TBTmkBDSseYqzoIZrkYW9SIX7DTcDtWHF30ZnW2ucCVi7iadfXMxJxG/aZ
gp5ErANEz+fSijrYxR/L7qYH2P0QVzbRMKrRE1L561AyKt7lrmvhN229A9bXRhPD
QujHN3S+5eQvfmhYRLh4gwP6x1EVecnyqUEfpKwBuz/iLA/GnxmosSIZ7f6naBpV
QINOsLSQy0qo2xSe8eJzELfF5Io/oOIhzRUpnDJfl7QV+c6IZ6jUcEjx7VhscXEl
XtnfepM6KPfhLZ0mEFKVPiDNbl+bc7SH5eNQMjKV8EP4eOpbsW7vE6mjS5VUJO7P
yKP29zlGGOt/2ZlE/vZoNRwF5CamPFq+ecfxMuGB/hX3jEDHLEFKbUiYS5QLZg0L
xi+jTQvSKW/rgxBwhp7/LD+smNLdEBf8Qq52Vu7FIA3sojp34aWu2GiIgcwTqjUz
MTNAQcQaveRqdwVlPvxOxZzF+naTtIDdJpu1nbTO7wVoq/D0+xYE6znSfkHpMkmE
/yoUNWWgLD4UWIZoEQZ4u+pX9Q1gvzpV+hugJIE/WLh0NkPItLeg+jI5xtZuya9q
jV0yungtnLHPfbiIbUzfXnsA9qnDBzKN70sUVBGXs6rpZpXcJUkd9cscgguYBVDD
fUdvapSvrWJjHocH5hfFipoma0MqNXKZkWXvl49UFuaYnjPT7pgGegRbsNTHXQg7
QFfUNtsq9tn8RvhNnox02yS3rEYHCgrrHqEBcpv8czkhWhKjvRnxcI5DDGsP7wDT
XD+PKx0IAie/meq0+cFL27gzvhHW9K8nkzE+sGG2p2gn+xMr4pT8galDLLkS3B7y
Q9CqD4G8qp3Sw7fzSm4PDuuDSstGZJ/iq/0cMfEJ/h4sZamH22zlL0PPeyR2/9/p
2EeNC7a0eF6/rx2FRTgrCos/KZbgxH2sS7B+xelAmCQIa7JFf/rvlxwgq89egPzc
r0JA9cCYh914PuPbegmgyygANI2aBqavEdW80WDL543Xlp3akQetJq506P1wUuV4
bGL5YMTY1HYs2wRbwMjwEZXTwrZfXW2r2n11+GVez7Enz/v+IHwe4EiQw0nkNcFK
x0VxAYHQMuNeaJjelXhSaGtli+N41/lmVI7nvKyczyJMVvcy3u06uY+N2ioF/agO
da7iVVPsycOLYTwjf2ggid4vfhosdYJJl9NLgpZqrjB8YMqFUyAluUjwVWY6q7/N
S0pgKS+OC/DmIHRcOQ+s0jQjhel3dFS8hYRNrPQJY7eclpiIHsPfOKwczZc12qRV
+eode8yPgYjVCu3hFoN+DiuvLrwn/XQdkOnbM45CRpFqTFWyzHBR3yp2vIQB7y8Z
c5av0mlUewe52kxl6xR7Kg7MvV1dpzEHk9RG0XkyeQHYwGZbMiNBgC3aaX7YHN2R
gUjEbbGKTnkX56bNjlJz+zx3y0WPVMQ6/UgancLRG4UPcbnva93KzdNNngXQCb2+
Jwksuu7dPTEoiJQU10FU6qTJ8VkgOMYdzazy0mLfHWI8vDG2pdakLw+kWmCjDPQQ
RlK+dSUd+/F6UhBrL3Ak2EN/7Qkbys75rwDaPYA+VX2flsfJLrF3PSDzyvdv6GlI
k5IHjjrzF6mg/pgyhHKzGmCJs91PJCoU5cRO8txgT/63vp4Hvh/0JqqFsG2+i6Ww
HAXnUMCDVBtjazzya/2xZERkhsu2wPR4HVFN7jwpBFbKBEtCHs2IpJefKqwNzhup
qYczw5ftKqXOLnm0aBt0umX3SX0l72naaPPKZf0g7668YfHvUF1LWRq1IECQh0d5
fohuqhz0lKnCDwRbThcRo5+5DLnezawETciB4PuwSlfHqDLd8G+rxZa7l8Vf9Hin
cEf9v4AN0dtdQAlOuWvJhW4RochnA98dUbRYti1hKX+rQRRJnv1YoYbI1+1rv+pO
3/etoTQdLmFPmNSCtXS0dA22GKKSTkw6PkPbiXkMWggOzJQpLIF3oRPX2XMTph3P
Jlz7jCrBT3pVhR+B4+yrLVrZHypnUUmWSzpKagFKf4+ge4a04T/IdZsCYgre12s/
iJCjby8D0qMRT7vlGTMh24HvSwozTsLWxDoOqHOXGdv9kbPkuipIOcCmZY1RJK/t
mT1vxx6cm9XJkm/1ij+o+XkJXdkLSqUBx4Urq20zXJI3NSoPVerpjx5qCqQsu3dG
FYP0MQNIZbIKhFujjlxgd42J72EOd+rJlvlznR8U223IRJO4AzMon/E/Wids3lpd
ZSBSYmsC6xHCiAG6ot13BEZOkTHVDn0vyzU5ajTvKyoIODBbtnBfpyZFkIMkCr9P
apXc930m8ks+Dxe8p0kHgEA5907E919u1oOqnSDl+V1M6j6D5U72gHGd73ZA9lI6
SpgLmECyG2pNVcKRzhgC
=Vy5h
-----END PGP SIGNATURE-----