[bt-devel] Close button on tabs

Jaak Ristioja jaak at ristioja.ee
Sat Aug 20 00:54:58 MST 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 20.08.2011 06:22, Gary Holmlund wrote:
> Jaak,
> 
> I was looking at the feature requests and saw that the request to add
> close buttons to tabs would be easy to do. I checked it in a bit ago. I
> did not realize that you had recently assigned it to yourself until I
> went to close it. I am sorry for not checking this first.
> 
> Gary

Hi Gary!

No problem. This is not high-priority thing anyway. Thanks you for your
contribution! :) I took a quick look at your commit, and I have a few
small questions/issues about this:

* Are you sure the using findChildren() is ok? I mean it's recursive and
could match any QTabBar in the QObject chain. Maybe we should explicitly
use a QTabWidget for this MDI type.
* setTabsCloseable was introduced in Qt 4.5. Can anybody recall what was
the minimum Qt version we require?
* Do we really need to use disconnect() there?
* Changelog entry had extra space at the end of line (git diff printed
it out RED)
* #includes appear to be in non-alphabetical order (would be easier to
read imho).

Feel free to express your opinion and argue with me :)


Many blessings! :)
Jaak


PS: We should really consider setting up a better bug-tracker than the
one at SourceForge. I have a strong preference for Bugzilla because my
bug-reporting experience with projects like Gentoo Linux, Linux Kernel,
KDE, GNU GCC, RedHat etc have been mostly very positive with it. It
provides a lot better email notifications. I might try to setup Bugzilla
on my home server (just got a lot of more bandwidth) at some point...
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)

iQgcBAEBAgAGBQJOT2hOAAoJEHeFv6jk2xWmbMJAAISzcb9PVVwPZirnKQkwUYUJ
+Fglu8HJ7wbnhFTsZtb/gr51HJaCsmD0qtZ154T2qalmMtZM8RJ6tZ0jLPd/1IDS
zxts9fNkuVi3VFQKjje83q3lTPYtXFK3nJZoJUcf2OHdZBdoijcdrQZIgELFmz+9
aWveAkM4EWEHKpzcFaxHx98P3BzFZJSStf5Fl66pizA7GULojG3K+bn5UTWBLscM
ggHeSNXpppgtYx6zuYCGgfO0JD+rVeaApA/nrIQPhgnweiwAmh0brenEVGzxgZw8
yMmNwd0GHRWm5vvrvUEToAtYiFPyq+LI2Z6njVv1urdP3y86nrY+T4Ht86krzcXa
REvSudYDXi/PNc3yzsPgCY1jLTB5rkHuBAiZHgEGDuhlKmgrXrBXZA/TgTOonm6J
lwlv1Fr+P/VaQQrMkXWWkU7yq6O0lnEpg3I2GEXcHH9qlPWIVab4u8pll6PI7mi8
BGgtXLiA3VR6j980uv2ZtufRkRLb9ACyP1NFp22LZSwi0GLyCfJwc+Oe+PPO7S6q
wwAltCte1htu2zBolgL8iK0Ok6HmUeRGjmwF/Bwurupkid2lY/or/i+4xsyFeqvw
+Y9dGK833/71CSRQ7pyoU8wn+xKmJKq9Wljiy1jde5lKh2ZM7t8sOHGDbb8zveP6
t/aSnYGfJwNIfIbWi0moZrULJvzAIi9rVpedY3cL/4L8i4pDYxAj+4fVR6pydM5F
m0Uad/X6Y4bc5SPNDMUID/DYPLekYcaI7xoeVbIDJ3YvOUYR4gPfzXwNhOWaZL8p
OD9qiTPU/hD8a1/vX+weU/22pdFialSqNPpmt02vswKow9BQ8PCspSWdgaP5Fb4l
zptc9EU6Az4YelRCYWJfeYiXsxE+GpeJJzo34ZzNTUghU6gwCzOsY/z5Vqg0QJ69
q/3kbttxac1hE8bStBq4QB55cWi5KW+AIKpNdpPRbCdiuQtvBk38x8tDj9EVTd3D
ZdG1up2iEVkkfSqRRJZ3Cdzc0uWzK+JyqwldT1oE3w2rJ0W3TDf00XhDO1ihgnNT
pCLlam/xDhuAfROZjlKHSbMDDj0uUq5OZHxGSX9KS1V+9Jzbmlhrw/UOhWRMWmGh
L7oEF6nq/i0a94CrhCND8N2dx7n0XeX/F1bqJLqDkdpdL2tqIghW2gLM/xeMll9S
zUU0Y59onf+rExAM/fDTaHlGuVOR+DzEo6JpL7EbRwO02MufAQE77PGzyAzgODDX
Mdd+7SLnu9F7T12RmfhpMYx7Ps7b43h1IbYv3wXGRt/tlR/xRu8mhWWQSXZc2FEE
GB6uwJKidCDDVVKLuO10EvxLvNddf469RX8kNiDSGqZsLRRotApS+3X1tfSb3qjg
VmJSm2Q67g/1rkrkUmmD8+OcMj4dANBHw4Fe1RTk5Pvr3D/+hyQbFRkb9+s4MGpQ
/aN//S0qd7gAhUKmPWDH+QVcWgl7IZHV0CogipnSUIgkF66uVBSgLXUSffw+Y6eO
GmcIwbSRJVUrcabS17OY6lCEExVYmOwSGx3dds1JxEa9LVx0sbRnTU2wzmWoBcsc
OWIsFz2uVepVX18LhwUOZ8gmlJVCwwFDwRQUqGoAPjvoQcrYuJ9/iEY07DK3fAwW
x/QDuzutIKvR1U8F8Nbsri/kJGCyzjvhdnvdGL9q9SDhLLsct0mOE+ANCKAh2tsx
BLwy1yhN2qb8JR+IpPGqqMlAKDhjMur1w1AKOAt3Zy148/cLJuOJ9TvcMM+ftnmH
9t/MOjLn1Sn5b75Tyv16SvYi0cY0PrbMQ/z28mYMT+T62QkkuZ0EOsw0HsMoT/ij
f6UobEDo7qqwltvGJztweycfm76mgmpAgC00XQ1aE+dfZxLf3IZanYSjRZdynX8K
1KiX5avx0UIMTWGDYZd9HN3PCCDmltAR/PqQsXsjxZcltAM8DYtcGXHKl6hNXnxF
n0nvhECYakBg3G8nn8LkLf+3jjmzV9E2CjhbnPMJnaZ6CJZ9W+TQI3Uem45b+Gt0
I7uKv8k8/LKyVdzVRivOOc3ttTua4jWccQmoI+mx9rviXJtCoYDwj7jk7tyGU3gn
V8cFx76xZyhT12KjTCO1RRmuDxQq8Uo0DILpoO5iU/Vt8u5HBzOx1iXGxnWFjBwg
TW1Taaq9sm+NlBaP5wkc1Vr0AtDWiCQx9lMOXxDbaswyWTzBeV4jiZwq2M3CmFf1
NmNoM5FPD4Po3NSbD3M+iPVDYtn7h60b1GHBS/ZO8LAFvjg96P8NvyYke5vIX8mb
ynuvfGARC4S8/40+a9MnXKaIIf9J7/wx7nhh9m6KmXb2fXzg921MlD+HrbCo4eue
YFasZFG6E8fSo3A8R8hdiy/F5TLfokODVX+17ldY2o4+McXF0FlRLUWEXyoFNMO6
1DKADYGS4hbxE7pNoE9cxBCBrQUWPkjnWe3zpLKvTzDVlB21kq9/ND+0tD4G+0Aw
Jw51oMz4otzx9FteNDMc+hz44HA8rqzq5VbGkuouImtyBBD7k7x1tsxwZluRhYDp
VnjgQ/MxX21vxvyCRv7kIX5xTm2OcEtrOvDJfX5MHzX1IM8DZ1LjGml9zOjBkJ5P
xDCLVwOXrg1L8nSywNkyKUDuWVXLmOI5jxZD/31LNFLi9ixyPLAhsajLQfnYWqbG
gGw+H8rk2cSZKPRqDL8b86xPyKkI8b5hNk+As1DGvSR4+quCo7wrJko+VWFpPBHd
NpSQX7MIcHZnnaDWbcVT
=NmXt
-----END PGP SIGNATURE-----



More information about the bt-devel mailing list