[bt-devel] About window size is too weite

Jaak Ristioja Ristioja at gmail.com
Tue Dec 7 00:55:16 MST 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07.12.2010 09:28, Jaak Ristioja wrote:
> On 06.12.2010 19:19, Olaf Radicke wrote:
>> here  is my proposal for solution as patch...
> 
> It's a very good idea to use a tooltip for that. I like it. :)
> 
> If you want me to accept your patch, it needs two minor modifications:
> 
>   1) Add the title label (e.g. QLabel *m_title;) to the private fields
> of BtAboutDialog.
> 
>   2) Move m_title->setToolTip(tr("Build: ") BT_VERSION_BUILD); into the
> retranslateUi() method. Note the usage of tr() and the extra space after
> the colon.
> 
> In addition, please send us the final patch using "git format-patch" so
> that your credentials would be listed in the git log. Thanks!

Actually I just found out that Gary already silently committed a fix for
this yesterday.

However, it would still be nice to have BT_VERSION and BT_VERSION_BUILD
as separate macros, and a tooltip for m_versionLabel to show the
BT_VERSION_BUILD in full. And I think that since people reference git
builds using the left part of the git hash, we should use Qt::ElideRight
instead of Qt::ElideMiddle.


Blessings!
Jaak


PS: My Qt Creator + Assistant setup is currently broken and new versions
fail to build on Hardened Gentoo, so I'm not much into coding right now.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)

iQgcBAEBAgAGBQJM/ehgAAoJEHeFv6jk2xWmHmg//j6Q+IhFRevAWAGClYJxzoTP
N23Xq6AuegBamyhiYDb6X3RBEK5dCU+xJsirt6xGNK1bAtzzYxjyqD9f/YlWIn+J
5eDKKpCpN8rbuZ/nr+/Sn/wS9b8OUGTfIZKCnk7FCNwjW+Sg4oboOxBxQwts9O0U
Keu5Ybxq4ltCc+X3bg4HyO2Box4GWPm2CUfElFhx5D+X+iAYKNvKwmKs/6LRWfvV
79jeGtizsvNU2YptB3iKL8R8YuWQ313fisxMzOlV4SiCFbtSVlrIBz1a2pq6rA32
C2ckc4/tL5Hva8W94w8gOD4NHBxRO3vu1bzrFzXPVxaIX6QZlUkHwJVGsslLveZZ
OaRcEqHYG5MsVfqdYVipC+lyCmTMSWXnr7z8SHo3tei1YIOkZVAitL0AoZ2/HKjZ
vXO2RM5pY9++tCCZ9q3BVWhnzpPcLr862jlkM5nzl+ECSbNMaOep5ZPPTzQ2NilI
zJFN10gxo/DV3dHpgmNhHhp5W6i4Zx+98j/idN6bcVftklJ4sVjFmCDoRofltfa4
HAszySJE25jUQ7DHPRTzQ8EvtgLG/ZTD2UxSEEZBN/oj3pJMa0kREi/0W9RZHUS/
iqN8tjb37FbQ0UDYgorbOGd28k/MYShWI5MOygRuup8FUHL7wl7CYlT+qY845+7L
3+o65j2o0BfNkomTTNhHQ1B1tPJzbrm6+8t/d+14A/iRdoama/DJfZPhmU6EHhgz
OKjBb7OZL9EOdxQRUzRP3T4iFvadI12QTgKGSW4usRXtQbpnYMlb5HUpq/w3Uh4P
dYg4xMBq/zJtju/jQXdD4D6iPOXsslNCjT7vdJUBlCi9O2LsOhmwoeW4Sr9FF6B1
jJyHsHF3DsnVGxdfBEEXvfaYAAdZ7lxYU/FFeQt9LLcteJwogacXsdRgAAKY4PUr
fnmiLlRDSXwe3dpT7S2xV/dE2ClaUyRSjMs3nOhUfr6ZMJ8BK0raa7bzcNd4X4D+
D2rw+0dIiuzuANtqpEAAdFv0IycSqRToilUZf7FxooWS2T9Dv59UBzQjk3BEpqUo
Kml5CnqxsugNe5MRhJhzCwkxclMzGxnlM4WllGkE/Qk9wypZvRROw6HMf8u9lKc2
6iRTPQxnIUzwY4aR8A5XYz4Ws9zbLv6QCjRB5ViBaYPHKOnNL/umCI7TCAbBGxic
6drYwiJtWuT8TU/cRPbV9LOsNB1NOFUsCG6CTatGC1Ew4X2R9g3tXRej1q5d73yc
Lp/uJGzKAFQveqhlAWVtvZcPZ3qjIeoc7Pp09V81/yRRjg5JZXhKO+Z0VJQeZNnH
3KonkbpFrvWtXSSwckI8tDGL0UGAFuxy+XdXlSktM2NeEditNGwSOfFdYOiK7ICl
AlEuq8O1i0UdYqdPTV+/paJrXRqJoiy3reVYL8Xq235HVIonu4x1s4NmepikEPFC
t1oyCUAHOZLNOQ/vsXBgcaObeT8iC8jhvUrG17LQZZ+REXtFafQSLwDnd6qPn2Sa
eDIKbRsp345zdcbeydTS+p8YqKvzuHwhItmn+hbcTpAMKW/3FaCNmQhNr50EuaAF
ESdqDIqRTk95g8kRnGAuFIGw1DKctYzTdX7kR2erenyUAH7oskJZR0yAGjJmuzG9
XuG3gfxjI8QA302Hl4ruBt35Vb2CsdfULtWhFEXTUPJetYHtqvGGv53UiGOSQD5g
hMeTn9I2A2KfEoGL0jfNdkBqq7G2CuQm75BvG7ehUfqoKA1Gyz5Z9QcwbU77K4l6
QfjJFKytZzA87L66Um7j3xql/yVwlBMQm1StfeGSOTITRzAzdoTLo1V4cC4j3qM3
/MNVpaLKOoGlk0+2ucMxzYvAZCJ6hCnPMxHjC9ADGur8bwoWY6ISay5u9BgFVqJv
nHyVO6Bn79+omJaxTptOgd/5+VD4UpwqQPSelaEPV+4Hx6mZ/VuQiuKPFoKPuSYq
nM4rP/OvFjE2gZT/UlyMvX0NAWnq86prC2xHr9BAAKWNjhtp4suBQoV6Y/1sZ6xT
hH2oAyY9V3YmWwbHLAfyw9o3j/TPR6pBmfl6c3hvHnWrQbkKfW71R8YfU7DpOyRJ
RwmUFnlHuvYc+uO5Qz3igNybSAFe8hlmu68I0JtANGRihHrhacG7/FEiOiAHZSHw
Sc6I3ffySVF71NYufdHuqi32DVOOTn9oIXQKC5wShxruQBI2hzB2BpJDPi3oMA7B
EpfNIrWyPS86zWpGys/kVMxOoyF7KFGuEEIE2V+lN5kZO1A2UFUBRfN2DgsviPPB
PuhBIzA+xFzCiw8iq+OpNXoWTYIrIY+PBRiVzPyxCu+aDWtXRdG6Ivu3aWZg1vjA
CadpnrfXfRnsYWpVgWMWmqob39YCc7q4xvrpHy58hwzPh7p3xbdUYUmc5WtPpY59
NpAedOqwHd23P1L60C0a/Frl8ybVUvs6Jsh1na2uk5gnYzObXWsyp4pBM1bep8Ma
9VuzH/pHKz43P+A3OfTYno1RisTK6S0vxNLNbxn0tBws9vWpp6VM1DIILcoDETM5
EV1UJZNlhRzgUsRX9IdfUci9LFVJECR0KQ4vi74nmSm7gZZPPQ97EsgfPTxhDLDl
agoLVgE+6nWbKtkWRjZaExH4PeE2Mylh3Gd55jOnM6aUcJkvv8vRjCysVQtrpHwI
Rhe/vxO4NqwTWix4CBTfXIC7A1+JxqXo7DGEQSjXXxTmhzTIFP9hjRZkUpdFCBfr
RgxSoVPBq9xkOrSR7Lwg
=VmE+
-----END PGP SIGNATURE-----



More information about the bt-devel mailing list