[bt-devel] Problems with our OSIS handler (crashes with GerElb1905)

[Eeli Kaikkonen]

Tom Cornell wrote:
> In OSIS I am pretty certain the parts of a lemma attribute need to be
> space separated. So that comment seems backwards to me: shouldn't it
> be '|' that isn't allowed?
> I've noticed this code before, and been puzzled by it also.
> -Tom

Yes, I just noticed that KJV uses space separated attributes. But if | 
has ever been used as a separator and haven't been used in any other 
purpose, we can leave it there. I just have to change the code so that 
it doesn't crash on illegal attributes.


There's still the other problem, the weird
const bool skipFirst = ((val[0] == 'T') && ((val[1] == 'H') || (val[1] 
== 'H')));
The KJV Old Testament uses morphology codes like THnnnn, so this is for 
them - but why the || part? Should there be another letter, possibly G? 
I haven't seen such Tx codes in the NT or OT. Well, at least it works 
now, except the crash on illegal tags.

While writing this I explored the code and the problem further. The fix 
is very simple. Probably this code has never been triggered for anyone 
and the obvious bug has been hiding. I'll commit the fix immediately.

--Eeli Kaikkonen