[bt-devel] BibleTime 1.7 could display multiple lemmas properly, 2.0alpha2 cannot

Gary Holmlund gary.holmlund at gmail.com
Sun Mar 22 22:49:03 MST 2009


Tom Cornell wrote:
> On Sun, Mar 22, 2009 at 6:45 PM, Gary Holmlund <gary.holmlund at gmail.com> wrote:
>   
>> Thanks Tom for finding the source of the issue. It was caused when I ported
>> to QtWebkit from the previous KDE functions. I had to use javascript to get
>> the dom attributes. I passed these from javascript to c++ by concatnating
>> all attributes into a single string using "|" as the separator. I did not
>> realize that "|" was in use within attributes. I have modified the
>> javascript (bthtml.js) and the receiving c++ (bthtmljsobject.cpp) to use
>> "||" for the separator. Since the list of attributes is split prior to the
>> split within an attribute, this should work fine.
>>
>> I could not find a test case with multiple lemma attributes so if you know
>> of the test case please test this fix.
>>     
>
> Gary,
> Looks good. For the record, Tisch 2.5 (which is in the beta
> repository, under Ancient Greek (grc) Bibles) has multiple lemma
> components (strong's number, strong's lemma and ANLEX lemma), as well
> as a morph attribute, so it's a good test case for this kind of thing.
> -Tom
>   
Martin and Eeli,

I checked in a fix that addresses both of the following defects. What is 
the process for closing these defects? I did not see any way that I can 
do it on the SourceForge tracker.

2696069 Mag display depends on attribute order
2685185 Strongs search misses entries

Gary




More information about the bt-devel mailing list