[bt-devel] BibleTime 1.5.2 won't compile with KDE < 3.3

[Jeremy Erickson]

Hi,
	While we're at it, I should note that Qt 3.2 also produces a compile error,
due to changes in the way QEvent handles window state changes.  I was able to
get a robust fix for the Mandrake 10.0 build.  The following patch fixes the
compile errors without loss of functionality:

<beginning of diff>

--- bibletime/frontend/cmdiarea.cpp-orig	2005-10-21 13:41:38.000000000 -0500
+++ bibletime/frontend/cmdiarea.cpp	2005-10-21 13:55:55.000000000 -0500
@@ -279,16 +279,17 @@
 	QWidget* w = dynamic_cast<QWidget*>( o );
 	bool ret = QWorkspace::eventFilter(o,e);
 
-	if ( w && (e->type() == QEvent::WindowStateChange) ) {
-		if (o->inherits("CDisplayWindow") && ((w->windowState() & Qt::WindowMinimized) || w->isHidden())) { //window was minimized, trigger a tile/cascade update if necessary
+	if (w && o->inherits("CDisplayWindow")){
+		if ((e->type() == QEvent::ShowMinimized) || 
+			(e->type() == QEvent::Hide)){
 			triggerWindowUpdate();
 			ret = false;
 		}
-		else if (!o->inherits("CDisplayWindow")) {
-			qDebug("bad mdi child classname: %s", o->className());
-			o->dumpObjectInfo();
-			o->dumpObjectTree();
-		}
+	}
+	else if (!o->inherits("CDisplayWindow")){
+		qDebug("bad mdi child classname: %s", o->className());
+		o->dumpObjectInfo();
+		o->dumpObjectTree();
 	}
 
 	return ret; // standard event processing

<end of diff>

	It would probably be a good idea to use an #ifdef to use the original code
for Qt 3.3 and the patched code for earler versions of Qt.

-Jeremy Erickson

On Thursday 20 October 2005 11:22 am, Joachim Ansorg wrote:
> Hi,
>
> > 	Should I send the FC2 packages anyway, even though the "Find" menu
> > option doesn't work?
>
> Yes, please. We should probably get 1.5.3 out to fix those problems, i.e.
> to give a define or compile option to get a clean compile with KDE < 3.3
> but with disabled features.
>
> Thank you for your patience and your time!
> Joachim
> _______________________________________________
> bt-devel mailing list
> bt-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/bt-devel