PMD 5.0.1 Report

2013-06-19 - 00:06:26

Summary

Files	Total	Priority 1	Priority 2	Priority 3	Priority 4	Priority 5
55	78	0	5	73	0	0

org.crosswire.jsword.book.sword.ZVerseBackend

Prio	Begin Line	Method	Description
3	371	dumpIdxRaf	Avoid printStackTrace(); use a logger call instead.
3	383	dumpIdxRaf	Avoid printStackTrace(); use a logger call instead.
3	421	dumpCompRaf	Avoid printStackTrace(); use a logger call instead.
3	433	dumpCompRaf	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 4

org.crosswire.jsword.bridge.BookInstaller

Prio	Begin Line	Method	Description
3	280	main	Avoid printStackTrace(); use a logger call instead.
3	308	main	Avoid printStackTrace(); use a logger call instead.
3	323	main	Avoid printStackTrace(); use a logger call instead.
3	325	main	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 4

org.crosswire.jsword.book.sword.ConfigEntryTable

Prio	Begin Line	Method	Description
3	425	loadContents	Prefer StringBuffer over += for concatenating strings
3	889		The field name indicates a constant but its modifiers do not
3	890		The field name indicates a constant but its modifiers do not

Total number of violations for this class: 3

org.crosswire.jsword.examples.APIExamples

Prio	Begin Line	Method	Description
3	362	installBook	Avoid printStackTrace(); use a logger call instead.
3	395	installBook	Avoid printStackTrace(); use a logger call instead.
3	402	installBook	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 3

org.crosswire.common.diff.DiffCleanup

Prio	Begin Line	Method	Description
3	103	cleanupSemantic	Avoid empty while statements
3	226	cleanupEfficiency	Avoid empty while statements

Total number of violations for this class: 2

org.crosswire.common.util.Languages

Prio	Begin Line	Method	Description
3	68	getName	Avoid empty catch blocks
3	212		Avoid protected fields in a final class. Change to private or package access.

Total number of violations for this class: 2

org.crosswire.common.util.Logger

Prio	Begin Line	Method	Description
2	646		Use of modifier volatile is not recommended.
2	647		Use of modifier volatile is not recommended.

Total number of violations for this class: 2

org.crosswire.common.util.NetUtil

Prio	Begin Line	Method	Description
3	142	makeDirectory	These nested if statements could be combined
3	296	getAsFile	Do not add empty strings

Total number of violations for this class: 2

org.crosswire.jsword.book.OSISUtil

Prio	Begin Line	Method	Description
3	1083	rtfToOsis	This call to String.startsWith can be rewritten using String.charAt(0)
3	1193		Avoid unused private fields such as 'robinsonsPattern'.

Total number of violations for this class: 2

org.crosswire.jsword.book.filter.gbf.GBFFilter

Prio	Begin Line	Method	Description
3	69	clone	clone() method should be implemented only if implementing Cloneable interface
3	148	parseTags	Use opposite operator instead of the logic complement operator.

Total number of violations for this class: 2

org.crosswire.jsword.book.sword.RawLDBackend

Prio	Begin Line	Method	Description
3	146	get	Avoid empty catch blocks
3	148	get	Avoid empty catch blocks

Total number of violations for this class: 2

org.crosswire.jsword.book.sword.state.OpenFileStateManager

Prio	Begin Line	Method	Description
2	183		Use of modifier volatile is not recommended.
2	184		Use of modifier volatile is not recommended.

Total number of violations for this class: 2

org.crosswire.jsword.book.sword.state.ZLDBackendState

Prio	Begin Line	Method	Description
3	145	getLastUncompressed	Returning 'lastUncompressed' may expose an internal array.
3	158	setLastUncompressed	The user-supplied array 'lastUncompressed' is stored directly.

Total number of violations for this class: 2

org.crosswire.jsword.book.sword.state.ZVerseBackendState

Prio	Begin Line	Method	Description
3	184	getLastUncompressed	Returning 'lastUncompressed' may expose an internal array.
3	207	setLastUncompressed	The user-supplied array 'lastUncompressed' is stored directly.

Total number of violations for this class: 2

org.crosswire.jsword.bridge.BookIndexer

Prio	Begin Line	Method	Description
3	156	main	Avoid printStackTrace(); use a logger call instead.
3	163	main	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 2

org.crosswire.jsword.bridge.BookLookup

Prio	Begin Line	Method	Description
3	100	main	Avoid printStackTrace(); use a logger call instead.
3	103	main	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 2

org.crosswire.jsword.passage.AbstractKeyList

Prio	Begin Line	Method	Description
3	223	clone	clone() method should be implemented only if implementing Cloneable interface
3	262		StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time).

Total number of violations for this class: 2

gnu.gpl.GPLMsg

Prio	Begin Line	Method	Description
3	32		All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.

Total number of violations for this class: 1

gnu.lgpl.LGPLMsg

Prio	Begin Line	Method	Description
3	32		All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.

Total number of violations for this class: 1

org.crosswire.common.util.CWClassLoader

Prio	Begin Line	Method	Description
3	168	adjustPackageSearch	Prefer StringBuffer over += for concatenating strings

Total number of violations for this class: 1

org.crosswire.common.util.IOUtil

Prio	Begin Line	Method	Description
3	77	unpackZip	These nested if statements could be combined

Total number of violations for this class: 1

org.crosswire.common.util.Reporter

Prio	Begin Line	Method	Description
3	159	fireCapture	Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()

Total number of violations for this class: 1

org.crosswire.common.xml.SerializingContentHandler

Prio	Begin Line	Method	Description
3	202		StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time).

Total number of violations for this class: 1

org.crosswire.common.xml.TransformingSAXEventProvider

Prio	Begin Line	Method	Description
3	80	getTemplateInfo	These nested if statements could be combined

Total number of violations for this class: 1

org.crosswire.jsword.JSMsg

Prio	Begin Line	Method	Description
3	32		All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.

Total number of violations for this class: 1

org.crosswire.jsword.JSOtherMsg

Prio	Begin Line	Method	Description
3	32		All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.

Total number of violations for this class: 1

org.crosswire.jsword.book.BookData

Prio	Begin Line	Method	Description
3	127	getBooks	Returning 'books' may expose an internal array.

Total number of violations for this class: 1

org.crosswire.jsword.book.Bookmark

Prio	Begin Line	Method	Description
3	99	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.book.basic.DefaultBookmark

Prio	Begin Line	Method	Description
3	100	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.book.filter.FilterFactory

Prio	Begin Line	Method	Description
2	86		Use of modifier volatile is not recommended.

Total number of violations for this class: 1

org.crosswire.jsword.book.filter.osis.OSISFilter

Prio	Begin Line	Method	Description
3	100	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.book.filter.plaintext.PlainTextFilter

Prio	Begin Line	Method	Description
3	66	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.book.filter.thml.THMLFilter

Prio	Begin Line	Method	Description
3	94	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.book.readings.ReadingsBookDriver

Prio	Begin Line	Method	Description
3	63	getBooks	Returning 'books' may expose an internal array.

Total number of violations for this class: 1

org.crosswire.jsword.book.readings.ReadingsKey

Prio	Begin Line	Method	Description
3	105	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.book.sword.AbstractKeyBackend

Prio	Begin Line	Method	Description
3	150	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.book.sword.RawFileBackend

Prio	Begin Line	Method	Description
3	180	createDataTextFile	Prefer StringBuffer over += for concatenating strings

Total number of violations for this class: 1

org.crosswire.jsword.book.sword.SwordBook

Prio	Begin Line	Method	Description
3	160	addOSIS	Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()

Total number of violations for this class: 1

org.crosswire.jsword.bridge.BookExporter

Prio	Begin Line	Method	Description
3	97	main	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 1

org.crosswire.jsword.bridge.DwrBridge

Prio	Begin Line	Method	Description
3	128	getOSISString	Avoid empty catch blocks

Total number of violations for this class: 1

org.crosswire.jsword.examples.BibleToOsis

Prio	Begin Line	Method	Description
3	71	main	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 1

org.crosswire.jsword.index.lucene.LuceneIndex

Prio	Begin Line	Method	Description
3	214		These nested if statements could be combined

Total number of violations for this class: 1

org.crosswire.jsword.passage.AbstractPassage

Prio	Begin Line	Method	Description
3	117	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.BitwisePassage

Prio	Begin Line	Method	Description
3	115	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.DefaultLeafKeyList

Prio	Begin Line	Method	Description
3	240	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.DistinctPassage

Prio	Begin Line	Method	Description
3	101	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.Key

Prio	Begin Line	Method	Description
3	201	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.PassageTally

Prio	Begin Line	Method	Description
3	186	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.RangedPassage

Prio	Begin Line	Method	Description
3	104	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.ReadOnlyKeyList

Prio	Begin Line	Method	Description
3	214	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.ReadOnlyPassage

Prio	Begin Line	Method	Description
3	368	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.SynchronizedPassage

Prio	Begin Line	Method	Description
3	317	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.TreeKey

Prio	Begin Line	Method	Description
3	157	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.Verse

Prio	Begin Line	Method	Description
3	301	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.VerseRange

Prio	Begin Line	Method	Description
3	389	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

Generated by PMD 5.0.1 on 2013-06-19 - 00:06:26.