PMD 4.2.2 Report

2008-12-01 - 00:03:37

Summary

Files	Total	Priority 1	Priority 2	Priority 3	Priority 4	Priority 5
65	96	19	2	63	12	0

org.crosswire.common.diff.PatchEntry

Prio	Line	Method	Description
3		hasDifferences	Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()
3		getFirstDifference	Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()
3		removeFirstDifference	Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()
3		getLastDifference	Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()

Total number of violations for this class: 4

org.crosswire.jsword.bridge.BookInstaller

Prio	Line	Method	Description
3		main	Avoid printStackTrace(); use a logger call instead.
3		main	Avoid printStackTrace(); use a logger call instead.
3		main	Avoid printStackTrace(); use a logger call instead.
3		main	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 4

org.crosswire.bibledesktop.desktop.XSLTProperty

Prio	Line	Method	Description
1			A class which only has private constructors should be final
4			A getX() method which returns a boolean should be named isX()
4			A getX() method which returns a boolean should be named isX()

Total number of violations for this class: 3

org.crosswire.common.swing.ActionFactory

Prio	Line	Method	Description
3		buildActionMap	Avoid empty catch blocks
3		getOptionalActionString	Avoid empty catch blocks
3		getOptionalActionString	Avoid empty catch blocks

Total number of violations for this class: 3

org.crosswire.common.diff.DiffCleanup

Prio	Line	Method	Description
1			A class which only has private constructors should be final
3		cleanupSemantic	Avoid empty while statements
3		cleanupEfficiency	Avoid empty while statements

Total number of violations for this class: 3

org.crosswire.jsword.book.filter.gbf.GBFTags

Prio	Line	Method	Description
3		updateOsisStack	Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()
3		updateOsisStack	Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()
3		updateOsisStack	Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()

Total number of violations for this class: 3

org.crosswire.jsword.book.filter.thml.CustomHandler

Prio	Line	Method	Description
3		startElement	Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()
3		characters	Prefer StringBuffer over += for concatenating strings
3		endElement	Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()

Total number of violations for this class: 3

org.crosswire.jsword.book.sword.ConfigEntry

Prio	Line	Method	Description
3		addValue	Prefer StringBuffer over += for concatenating strings
3		toOSIS	Prefer StringBuffer over += for concatenating strings
3		toOSIS	Prefer StringBuffer over += for concatenating strings

Total number of violations for this class: 3

org.crosswire.jsword.examples.APIExamples

Prio	Line	Method	Description
3		installBook	Avoid printStackTrace(); use a logger call instead.
3		installBook	Avoid printStackTrace(); use a logger call instead.
3		installBook	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 3

org.crosswire.jsword.index.lucene.analysis.AnalyzerFactory

Prio	Line	Method	Description
1			A class which only has private constructors should be final
4			A getX() method which returns a boolean should be named isX()
4			A getX() method which returns a boolean should be named isX()

Total number of violations for this class: 3

org.crosswire.common.swing.NudgeButton

Prio	Line	Method	Description
4			A getX() method which returns a boolean should be named isX()
4			A getX() method which returns a boolean should be named isX()

Total number of violations for this class: 2

org.crosswire.common.diff.Commonality

Prio	Line	Method	Description
1			A class which only has private constructors should be final
3		halfMatch	Avoid assignments in operands

Total number of violations for this class: 2

org.crosswire.common.history.History

Prio	Line	Method	Description
3		getCurrent	Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()
2		visit	Avoid instantiating Long objects.Call Long.valueOf() instead

Total number of violations for this class: 2

org.crosswire.common.icu.DateFormatter

Prio	Line	Method	Description
1			A class which only has private constructors should be final
3		parse	An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type.

Total number of violations for this class: 2

org.crosswire.common.xml.XMLFeature

Prio	Line	Method	Description
1			A class which only has private constructors should be final
4			A getX() method which returns a boolean should be named isX()

Total number of violations for this class: 2

org.crosswire.jsword.book.sword.SwordBookDriver

Prio	Line	Method	Description
3		delete	Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()
3		delete	Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()

Total number of violations for this class: 2

org.crosswire.jsword.bridge.BookIndexer

Prio	Line	Method	Description
3		main	Avoid printStackTrace(); use a logger call instead.
3		main	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 2

org.crosswire.jsword.bridge.BookLookup

Prio	Line	Method	Description
3		main	Avoid printStackTrace(); use a logger call instead.
3		main	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 2

org.crosswire.jsword.bridge.DwrBridge

Prio	Line	Method	Description
3		getInstalledBooks	Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()
3		getOSISString	Avoid empty catch blocks

Total number of violations for this class: 2

org.crosswire.bibledesktop.book.BibleComboBoxModel

Prio	Line	Method	Description
1		getElementAt	A switch with less than 3 branches is inefficient, use a if statement instead.

Total number of violations for this class: 1

org.crosswire.bibledesktop.book.install.BookFont

Prio	Line	Method	Description
1			A class which only has private constructors should be final

Total number of violations for this class: 1

org.crosswire.bibledesktop.book.install.BookIcon

Prio	Line	Method	Description
1			A class which only has private constructors should be final

Total number of violations for this class: 1

org.crosswire.bibledesktop.desktop.Desktop

Prio	Line	Method	Description
3		checkForBooks	Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()

Total number of violations for this class: 1

org.crosswire.bibledesktop.display.basic.TabbedBookDataDisplay

Prio	Line	Method	Description
3		getBooks	Returning 'books' may expose an internal array.

Total number of violations for this class: 1

org.crosswire.bibledesktop.display.basic.TextPaneBookDataDisplay

Prio	Line	Method	Description
3		setBookData	The user-supplied array 'books' is stored directly.

Total number of violations for this class: 1

org.crosswire.bibledesktop.passage.KeySidebar

Prio	Line	Method	Description
3		doBlur	Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()

Total number of violations for this class: 1

org.crosswire.bibledesktop.passage.KeyTreeNode

Prio	Line	Method	Description
4			A getX() method which returns a boolean should be named isX()

Total number of violations for this class: 1

org.crosswire.bibledesktop.passage.WholeBibleTreeNode

Prio	Line	Method	Description
4			A getX() method which returns a boolean should be named isX()

Total number of violations for this class: 1

org.crosswire.common.config.swing.AdvancedConfigEditor

Prio	Line	Method	Description
3		getChild	Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()

Total number of violations for this class: 1

org.crosswire.common.progress.swing.JobsProgressBar

Prio	Line	Method	Description
3		createCancelButton	Consider simply returning the value vs storing it in local variable 'cancelButton'

Total number of violations for this class: 1

org.crosswire.common.swing.CWOptionPane

Prio	Line	Method	Description
3		styleFromMessageType	A switch statement does not contain a break

Total number of violations for this class: 1

org.crosswire.common.swing.desktop.LayoutPersistence

Prio	Line	Method	Description
1			A class which only has private constructors should be final

Total number of violations for this class: 1

org.crosswire.common.config.AbstractReflectedChoice

Prio	Line	Method	Description
3		setString	Avoid catching NullPointerException; consider removing the cause of the NPE.

Total number of violations for this class: 1

org.crosswire.common.diff.Distance

Prio	Line	Method	Description
1			A class which only has private constructors should be final

Total number of violations for this class: 1

org.crosswire.common.diff.Patch

Prio	Line	Method	Description
3		make	Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()

Total number of violations for this class: 1

org.crosswire.common.options.GetOptions

Prio	Line	Method	Description
3		parse	Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()

Total number of violations for this class: 1

org.crosswire.common.util.CWClassLoader

Prio	Line	Method	Description
3		adjustPackageSearch	Prefer StringBuffer over += for concatenating strings

Total number of violations for this class: 1

org.crosswire.common.util.Countries

Prio	Line	Method	Description
1			A class which only has private constructors should be final

Total number of violations for this class: 1

org.crosswire.common.util.Languages

Prio	Line	Method	Description
1			A class which only has private constructors should be final

Total number of violations for this class: 1

org.crosswire.common.util.Logger

Prio	Line	Method	Description
3		doLogging	This statement may have some unnecessary parentheses

Total number of violations for this class: 1

org.crosswire.common.util.LucidException

Prio	Line	Method	Description
3			The user-supplied array 'params' is stored directly.

Total number of violations for this class: 1

org.crosswire.common.util.NetUtil

Prio	Line	Method	Description
3		getAsFile	Do not add empty strings

Total number of violations for this class: 1

org.crosswire.common.util.PatternFormatter

Prio	Line	Method	Description
2		format	Avoid instantiating Long objects.Call Long.valueOf() instead

Total number of violations for this class: 1

org.crosswire.common.util.StringUtil

Prio	Line	Method	Description
3		toString	Avoid appending characters as strings in StringBuffer.append.

Total number of violations for this class: 1

org.crosswire.common.util.Translations

Prio	Line	Method	Description
1			A class which only has private constructors should be final

Total number of violations for this class: 1

org.crosswire.common.xml.SerializingContentHandler

Prio	Line	Method	Description
3			StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time).

Total number of violations for this class: 1

org.crosswire.common.xml.XMLFeatureSet

Prio	Line	Method	Description
4			A getX() method which returns a boolean should be named isX()

Total number of violations for this class: 1

org.crosswire.common.xml.XalanProcess

Prio	Line	Method	Description
1			A class which only has private constructors should be final

Total number of violations for this class: 1

org.crosswire.jsword.view.web.DownloadSet

Prio	Line	Method	Description
1			A class which only has private constructors should be final

Total number of violations for this class: 1

org.crosswire.jsword.view.web.Msg

Prio	Line	Method	Description
1			A class which only has private constructors should be final

Total number of violations for this class: 1

org.crosswire.jsword.book.BookData

Prio	Line	Method	Description
3		getBooks	Returning 'books' may expose an internal array.

Total number of violations for this class: 1

org.crosswire.jsword.book.OSISUtil

Prio	Line	Method	Description
3		rtfToOsis	This call to String.startsWith can be rewritten using String.charAt(0)

Total number of violations for this class: 1

org.crosswire.jsword.book.filter.osis.OSISFilter

Prio	Line	Method	Description
3		toOSIS	Prefer StringBuffer over += for concatenating strings

Total number of violations for this class: 1

org.crosswire.jsword.book.readings.ReadingsBookDriver

Prio	Line	Method	Description
3		getBooks	Returning 'books' may expose an internal array.

Total number of violations for this class: 1

org.crosswire.jsword.book.sword.ConfigEntryTable

Prio	Line	Method	Description
3		loadContents	Prefer StringBuffer over += for concatenating strings

Total number of violations for this class: 1

org.crosswire.jsword.book.sword.RawLDBackend

Prio	Line	Method	Description
3		get	Avoid empty catch blocks

Total number of violations for this class: 1

org.crosswire.jsword.bridge.BookExporter

Prio	Line	Method	Description
3		main	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 1

org.crosswire.jsword.examples.StrongsAnalysis

Prio	Line	Method	Description
3			Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()

Total number of violations for this class: 1

org.crosswire.jsword.index.lucene.IndexMetadata

Prio	Line	Method	Description
1			A class which only has private constructors should be final

Total number of violations for this class: 1

org.crosswire.jsword.index.lucene.LuceneIndex

Prio	Line	Method	Description
3			Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()

Total number of violations for this class: 1

org.crosswire.jsword.index.lucene.analysis.AbstractBookAnalyzer

Prio	Line	Method	Description
4			A getX() method which returns a boolean should be named isX()

Total number of violations for this class: 1

org.crosswire.jsword.index.lucene.analysis.CzechLuceneAnalyzer

Prio	Line	Method	Description
3		setStopWords	The user-supplied array 'stopWords' is stored directly.

Total number of violations for this class: 1

org.crosswire.jsword.passage.AbstractKeyList

Prio	Line	Method	Description
3			StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time).

Total number of violations for this class: 1

org.crosswire.jsword.passage.PassageUtil

Prio	Line	Method	Description
4			A getX() method which returns a boolean should be named isX()

Total number of violations for this class: 1

org.crosswire.jsword.util.WebWarning

Prio	Line	Method	Description
1			A class which only has private constructors should be final

Total number of violations for this class: 1

Generated by PMD 4.2.2 on 2008-12-01 - 00:03:37.